lint

Author: cramforce

biome.json

@@ -7,16 +7,16 @@
       "recommended": true,
       "correctness": {
         "noUnusedImports": "error",
-        "noUnusedVariables": "warn"
+        "noUnusedVariables": "error"
       },
       "suspicious": {
         "noTemplateCurlyInString": "off",
         "noControlCharactersInRegex": "off",
-        "noImplicitAnyLet": "warn",
-        "noAssignInExpressions": "warn"
+        "noImplicitAnyLet": "error",
+        "noAssignInExpressions": "error"
       },
       "style": {
-        "noNonNullAssertion": "warn"
+        "noNonNullAssertion": "error"
       }
     }
   },

package.json

@@ -14,8 +14,8 @@
     "lint:fix": "biome check --write .",
     "test": "vitest",
     "test:run": "vitest run",
-    "test:unit": "vitest run --exclude='**/comparison/**'",
-    "test:comparison": "vitest run src/comparison",
+    "test:unit": "vitest run --config vitest.unit.config.ts",
+    "test:comparison": "vitest run --config vitest.comparison.config.ts",
     "shell": "npx tsx src/cli/shell.ts"
   },
   "keywords": [],

src/BashEnv.ts

@@ -880,12 +880,14 @@ export class BashEnv {
       this.callDepth--;
 
       // Pop the local scope and restore shadowed variables
-      const localScope = this.localScopes.pop()!;
-      for (const [varName, originalValue] of localScope) {
-        if (originalValue === undefined) {
-          delete this.env[varName];
-        } else {
-          this.env[varName] = originalValue;
+      const localScope = this.localScopes.pop();
+      if (localScope) {
+        for (const [varName, originalValue] of localScope) {
+          if (originalValue === undefined) {
+            delete this.env[varName];
+          } else {
+            this.env[varName] = originalValue;
+          }
         }
       }
 

src/commands/basename/basename.ts

@@ -49,7 +49,7 @@ export const basenameCommand: Command = {
 
     // If not multiple mode, second arg is suffix
     if (!multiple && names.length >= 2) {
-      suffix = names.pop()!;
+      suffix = names.pop() ?? "";
     }
 
     const results: string[] = [];

src/commands/cp/cp.ts

@@ -32,7 +32,7 @@ export const cpCommand: Command = {
       };
     }
 
-    const dest = paths.pop()!;
+    const dest = paths.pop() ?? "";
     const sources = paths;
     const destPath = ctx.fs.resolvePath(ctx.cwd, dest);
 

src/commands/find/find.ts

@@ -305,12 +305,13 @@ export const findCommand: Command = {
         return;
       }
 
-      let stat;
+      let stat: Awaited<ReturnType<typeof ctx.fs.stat>> | undefined;
       try {
         stat = await ctx.fs.stat(currentPath);
       } catch {
         return;
       }
+      if (!stat) return;
 
       // For the starting directory, use the search path itself as the name
       // (e.g., when searching from '.', the name should be '.')

src/commands/grep/grep.ts

@@ -412,8 +412,11 @@ function grepContent(
       if (onlyMatching) {
         // Output only the matched parts
         regex.lastIndex = 0;
-        let match;
-        while ((match = regex.exec(line)) !== null) {
+        for (
+          let match = regex.exec(line);
+          match !== null;
+          match = regex.exec(line)
+        ) {
           let outputLine = match[0];
           if (filename) {
             outputLine = `${filename}:${outputLine}`;

src/commands/mv/mv.ts

@@ -26,7 +26,7 @@ export const mvCommand: Command = {
       };
     }
 
-    const dest = paths.pop()!;
+    const dest = paths.pop() ?? "";
     const sources = paths;
     const destPath = ctx.fs.resolvePath(ctx.cwd, dest);
 

src/commands/printf/printf.ts

@@ -152,9 +152,12 @@ function convertArgs(format: string, args: string[]): (string | number)[] {
 
   // Match format specifiers: %[flags][width][.precision][length]specifier
   const specifierRegex = /%[-+0 #]*\d*(?:\.\d+)?[hlL]?([diouxXeEfFgGaAcspn%])/g;
-  let match;
 
-  while ((match = specifierRegex.exec(format)) !== null) {
+  for (
+    let match = specifierRegex.exec(format);
+    match !== null;
+    match = specifierRegex.exec(format)
+  ) {
     const specifier = match[1];
 
     if (specifier === "%") {

src/commands/sed/sed.ts

@@ -229,15 +229,15 @@ export const sedCommand: Command = {
           lineStart === undefined ||
           (lineNum >= lineStart && lineNum <= (lineEnd ?? lineStart));
 
-        if (sedCmd.type === "substitute" && inRange) {
+        if (sedCmd.type === "substitute" && inRange && sedCmd.pattern) {
           let flags = "";
           if (sedCmd.global) flags += "g";
           if (sedCmd.ignoreCase) flags += "i";
-          const regex = new RegExp(sedCmd.pattern!, flags);
+          const regex = new RegExp(sedCmd.pattern, flags);
 
           // Handle & replacement
           line = line.replace(regex, (match) =>
-            processReplacement(sedCmd.replacement!, match),
+            processReplacement(sedCmd.replacement ?? "", match),
           );
         } else if (sedCmd.type === "delete") {
           if (sedCmd.addressPattern) {
@@ -315,13 +315,13 @@ export const sedCommand: Command = {
               lineStart === undefined ||
               (lineNum >= lineStart && lineNum <= (lineEnd ?? lineStart));
 
-            if (sedCmd.type === "substitute" && inRange) {
+            if (sedCmd.type === "substitute" && inRange && sedCmd.pattern) {
               let flags = "";
               if (sedCmd.global) flags += "g";
               if (sedCmd.ignoreCase) flags += "i";
-              const regex = new RegExp(sedCmd.pattern!, flags);
+              const regex = new RegExp(sedCmd.pattern, flags);
               line = line.replace(regex, (match) =>
-                processReplacement(sedCmd.replacement!, match),
+                processReplacement(sedCmd.replacement ?? "", match),
               );
             } else if (sedCmd.type === "delete") {
               if (sedCmd.addressPattern) {