Remove any type and make removeEdgesAndNodes generic (#1353)

harrybuisman · web-flow · commit 7c1b34abdb70 · 2024-07-14T12:20:15.000-05:00
diff --git a/lib/shopify/index.ts b/lib/shopify/index.ts
@@ -114,7 +114,7 @@ export async function shopifyFetch<T>({
   }
 }
 
-const removeEdgesAndNodes = (array: Connection<any>) => {
+const removeEdgesAndNodes = <T>(array: Connection<T>): T[] => {
   return array.edges.map((edge) => edge?.node);
 };
 
@@ -163,7 +163,7 @@ const reshapeImages = (images: Connection<Image>, productTitle: string) => {
   const flattened = removeEdgesAndNodes(images);
 
   return flattened.map((image) => {
-    const filename = image.url.match(/.*\/(.*)\..*/)[1];
+    const filename = image.url.match(/.*\/(.*)\..*/)?.[1];
     return {
       ...image,
       altText: image.altText || `${productTitle} - ${filename}`

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ export async function shopifyFetch<T>({`
`114`	`114`	`}`
`115`	`115`	`}`
`116`	`116`
`117`		`-const removeEdgesAndNodes = (array: Connection<any>) => {`
	`117`	`+const removeEdgesAndNodes = <T>(array: Connection<T>): T[] => {`
`118`	`118`	`return array.edges.map((edge) => edge?.node);`
`119`	`119`	`};`
`120`	`120`
`@@ -163,7 +163,7 @@ const reshapeImages = (images: Connection<Image>, productTitle: string) => {`
`163`	`163`	`const flattened = removeEdgesAndNodes(images);`
`164`	`164`
`165`	`165`	`return flattened.map((image) => {`
`166`		`- const filename = image.url.match(/.\/(.)\..*/)[1];`
	`166`	`+ const filename = image.url.match(/.\/(.)\..*/)?.[1];`
`167`	`167`	`return {`
`168`	`168`	`...image,`
`169`	`169`	altText: image.altText \|\| `${productTitle} - ${filename}`