Remove render server#94602
Draft
timneutkens wants to merge 1 commit into
Draft
Conversation
Contributor
Failing test suitesCommit: f6e8e65 | About building and testing Next.js
Expand output● hmr-deleted-page › should not show errors for a deleted page |
Contributor
Stats cancelledCommit: f6e8e65 |
5111525 to
2e1089d
Compare
2e1089d to
f6e8e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the obsolete
render-server.tslifecycle adapter and instantiateNextServerdirectly fromrouter-server.ts.Why?
The adapter no longer provides a meaningful process boundary. It duplicates server initialization and keeps directory-keyed lifecycle state that can instead be owned directly by each router-server initialization.
How?
Move
ServerInitResultinto shared server types, capture the preparedNextServerand request handler inrouter-server.ts, pass explicit dev lifecycle callbacks into bundler setup, route requests through the prepared handler, import sandbox cache-clearing helpers directly from their context module, and remove the obsolete render-worker compatibility environment variable.Verification
pnpm prettier --with-node-modules --ignore-path .prettierignore --write <changed files>npx eslint --config eslint.config.mjs --fix <changed files>pnpm --filter=next typespnpm --filter=next buildNEXT_TEST_PREFER_OFFLINE=1 pnpm test-dev-turbo test/e2e/custom-server/custom-server.test.tsNEXT_TEST_PREFER_OFFLINE=1 pnpm test-dev-webpack test/e2e/custom-server/custom-server.test.tsNEXT_TEST_PREFER_OFFLINE=1 pnpm test-start-webpack test/e2e/custom-server/custom-server.test.tsNEXT_TEST_PREFER_OFFLINE=1 pnpm test-dev-turbo test/development/app-hmr/hmr-env.test.tsNEXT_TEST_PREFER_OFFLINE=1 pnpm test-dev-webpack test/development/app-hmr/hmr-env.test.ts