Skip to content

Rust target binaries are included in the final directory #202

Description

@TheComputerGuy96

Currently this library tries to recursively include all .so libraries in a directory when a .node file is detected in the same directory, which is probably fine in most cases (but not when you're trying to build a native library with Rust because its target directory is included due to the .so files inside, which aren't needed in most cases and increase the final directory size)

This notably affects Proton Pass (which has a native Rust component) by increasing the size of the final .asar file as prepared by Electron Forge

Custom emit filter has no effect here because the .so emitting is a consequence of the .node files (and they aren't passed through the filter-compatible functions either)

Let me know if you need a simple test case for this

Edit: #73 vaguely mentions this issue (but it doesn't seem to be a good enough bug report)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions