[MIG] sale_order_line_description: Migration to 18.0

Author: Qlasta

sale_order_line_description/__manifest__.py

@@ -2,7 +2,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 {
     "name": "Sale order line description",
-    "version": "15.0.1.0.0",
+    "version": "18.0.1.0.0",
     "category": "Sales Management",
     "author": "Agile Business Group, " "Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/sale-workflow",

sale_order_line_description/i18n/sale_order_line_description.pot

@@ -4,7 +4,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: Odoo Server 15.0\n"
+"Project-Id-Version: Odoo Server 18.0\n"
 "Report-Msgid-Bugs-To: \n"
 "Last-Translator: \n"
 "Language-Team: \n"

sale_order_line_description/models/sale_order_line.py

@@ -1,19 +1,15 @@
 # Copyright 2013-15 Agile Business Group sagl (<http://www.agilebg.com>)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, models
+from odoo import models
 
 
 class SaleOrderLine(models.Model):
     _inherit = "sale.order.line"
 
-    @api.onchange("product_id")
-    def product_id_change(self):
-        res = super().product_id_change()
-        if not self.product_id:  # pragma: no cover
-            return res
+    def _get_sale_order_line_multiline_description_sale(self):
         if (
-            self.user_has_groups(
+            self.env.user.has_group(
                 "sale_order_line_description."
                 "group_use_product_description_per_so_line"
             )
@@ -24,5 +20,5 @@ def product_id_change(self):
                 product = product.with_context(
                     lang=self.order_id.partner_id.lang,
                 )
-            self.name = product.description_sale
-        return res
+            return product.description_sale
+        return super()._get_sale_order_line_multiline_description_sale()

sale_order_line_description/tests/test_sale.py

@@ -7,35 +7,35 @@
 
 @tagged("post_install", "-at_install")
 class TestSaleOrderLineDescriptionChange(common.TransactionCase):
-    def setUp(self):
-        super().setUp()
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
 
         # Create models
-        self.sale_order_model = self.env["sale.order"]
-        self.sale_order_line_model = self.env["sale.order.line"]
-        self.partner_model = self.env["res.partner"]
-        self.product_model = self.env["product.product"]
-        self.user_model = self.env["res.users"].with_context(
+        cls.sale_order_model = cls.env["sale.order"]
+        cls.sale_order_line_model = cls.env["sale.order.line"]
+        cls.partner_model = cls.env["res.partner"]
+        cls.product_model = cls.env["product.product"]
+        cls.user_model = cls.env["res.users"].with_context(
             no_reset_password=True, mail_create_nosubscribe=True
         )
 
-        # Create two different users
-        self.group_only_sale_description = self.env.ref(
+        # Create user group
+        cls.group_only_sale_description = cls.env.ref(
             "sale_order_line_description.group_use_product_description_per_so_line"
         )
-        self.user_1 = self._create_user("TestUser1")
-        self.user_2 = self._create_user("TestUser2", self.group_only_sale_description)
 
         # Create the sale order
-        self.partner = self.partner_model.create({"name": "Test partner"})
-        self.sale_order = self.sale_order_model.create({"partner_id": self.partner.id})
+        cls.partner = cls.partner_model.create({"name": "Test partner"})
+        cls.sale_order = cls.sale_order_model.create({"partner_id": cls.partner.id})
 
-        self.product = self.product_model.create(
+        cls.product = cls.product_model.create(
             {
                 "name": "Test product",
                 "description_sale": "Sale description for test product",
             }
         )
+        cls.line_values = {"order_id": cls.sale_order.id, "product_id": cls.product.id}
 
     def _create_user(self, name, group=None):
         groups_id = self.env.user.groups_id
@@ -50,24 +50,29 @@ def _create_user(self, name, group=None):
             }
         )
 
-    def test_check_sale_order_line_description(self):
-        line_values = {"order_id": self.sale_order.id, "product_id": self.product.id}
-
-        # Create sale order line with TestUser1
+    def test_01_check_sale_order_line_description_standard(self):
+        # GIVEN
+        self.user_1 = self._create_user("TestUser1")
+        # WHEN
         sale_order_line = self.sale_order_line_model.with_user(self.user_1).create(
-            line_values.copy()
+            self.line_values.copy()
         )
+        # THEN
         self.assertEqual(
             sale_order_line.name,
             "\n".join([self.product.name, self.product.description_sale]),
             "Standard behavior does not concatenate "
             "product description and product sale description",
         )
 
-        # Create sale order line with TestUser2
+    def test_02_check_sale_order_line_description_with_group(self):
+        # GIVEN
+        self.user_2 = self._create_user("TestUser2", self.group_only_sale_description)
+        # WHEN
         sale_order_line = self.sale_order_line_model.with_user(self.user_2).create(
-            line_values.copy()
+            self.line_values.copy()
         )
+        # THEN
         self.assertEqual(
             sale_order_line.name,
             self.product.description_sale,

sale_order_line_description/views/res_config_settings_views.xml

@@ -4,24 +4,13 @@
         <field name="model">res.config.settings</field>
         <field name="inherit_id" ref="sale.res_config_settings_view_form" />
         <field name="arch" type="xml">
-            <xpath
-                expr="//field[@name='group_auto_done_setting']/../.."
-                position="after"
-            >
-                <div class="col-xs-12 col-md-6 o_setting_box">
-                    <div class="o_setting_left_pane">
-                        <field name="group_use_product_description_per_so_line" />
-                    </div>
-                    <div class="o_setting_right_pane">
-                        <label
-                            for="group_use_product_description_per_so_line"
-                            string="Product sale description"
-                        />
-                        <div class="text-muted">
-                            Allows you to use only product sale description on the sales order line
-                        </div>
-                    </div>
-                </div>
+            <xpath expr="//setting[@id='no_edit_order']" position="after">
+                <setting
+                    string="Sales Order Line Description"
+                    help="Allows you to use only product sale description on the sales order line"
+                >
+                    <field name="group_use_product_description_per_so_line" />
+                </setting>
             </xpath>
         </field>
     </record>