Skip to content

Commit 8c75487

Browse files
committed
cosmetic
1 parent 662938e commit 8c75487

5 files changed

Lines changed: 62 additions & 44 deletions

File tree

src/Consumer.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,10 @@ export class Consumer<
223223

224224
// Emit observer event.
225225
this._observer.safeEmit('close');
226+
227+
// Invoke close() in EnhancedEventEmitter classes.
228+
super.close();
229+
this._observer.close();
226230
}
227231

228232
/**

src/DataConsumer.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,6 +201,10 @@ export class DataConsumer<
201201

202202
// Emit observer event.
203203
this._observer.safeEmit('close');
204+
205+
// Invoke close() in EnhancedEventEmitter classes.
206+
super.close();
207+
this._observer.close();
204208
}
205209

206210
private handleDataChannel(): void {
@@ -240,15 +244,21 @@ export class DataConsumer<
240244
return;
241245
}
242246

243-
logger.warn('DataChannel "close" event');
247+
logger.debug('DataChannel "close" event');
244248

245249
this._closed = true;
246250

251+
this._dataChannel.close();
252+
247253
this.emit('@close');
248254
this.safeEmit('close');
249255

250256
// Emit observer event.
251257
this._observer.safeEmit('close');
258+
259+
// Invoke close() in EnhancedEventEmitter classes.
260+
super.close();
261+
this._observer.close();
252262
});
253263

254264
this._dataChannel.addEventListener('message', event => {

src/DataProducer.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,10 @@ export class DataProducer<
196196

197197
// Emit observer event.
198198
this._observer.safeEmit('close');
199+
200+
// Invoke close() in EnhancedEventEmitter classes.
201+
super.close();
202+
this._observer.close();
199203
}
200204

201205
/**
@@ -251,15 +255,21 @@ export class DataProducer<
251255
return;
252256
}
253257

254-
logger.warn('DataChannel "close" event');
258+
logger.debug('DataChannel "close" event');
255259

256260
this._closed = true;
257261

262+
this._dataChannel.close();
263+
258264
this.emit('@close');
259265
this.safeEmit('close');
260266

261267
// Emit observer event.
262268
this._observer.safeEmit('close');
269+
270+
// Invoke close() in EnhancedEventEmitter classes.
271+
super.close();
272+
this._observer.close();
263273
});
264274

265275
this._dataChannel.addEventListener('message', () => {

src/Producer.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,10 @@ export class Producer<
283283

284284
// Emit observer event.
285285
this._observer.safeEmit('close');
286+
287+
// Invoke close() in EnhancedEventEmitter classes.
288+
super.close();
289+
this._observer.close();
286290
}
287291

288292
/**

src/Transport.ts

Lines changed: 32 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -478,10 +478,9 @@ export class Transport<
478478
}
479479

480480
// Enqueue command.
481-
return this._awaitQueue.push(
482-
async () => await this._handler.restartIce(iceParameters),
483-
'transport.restartIce()'
484-
);
481+
await this._awaitQueue.push(async () => {
482+
await this._handler.restartIce(iceParameters);
483+
}, 'transport.restartIce()');
485484
}
486485

487486
/**
@@ -499,10 +498,9 @@ export class Transport<
499498
}
500499

501500
// Enqueue command.
502-
return this._awaitQueue.push(
503-
async () => this._handler.updateIceServers(iceServers),
504-
'transport.updateIceServers()'
505-
);
501+
await this._awaitQueue.push(async () => {
502+
await this._handler.updateIceServers(iceServers);
503+
}, 'transport.updateIceServers()');
506504
}
507505

508506
/**
@@ -1186,7 +1184,7 @@ export class Transport<
11861184
handler.on(
11871185
'@icecandidateerror',
11881186
(event: RTCPeerConnectionIceErrorEvent) => {
1189-
logger.warn(
1187+
logger.debug(
11901188
`ICE candidate error [url:${event.url}, localAddress:${event.address}, localPort:${event.port}]: ${event.errorCode} "${event.errorText}"`
11911189
);
11921190

@@ -1218,69 +1216,61 @@ export class Transport<
12181216
}
12191217

12201218
this._awaitQueue
1221-
.push(
1222-
async () => await this._handler.stopSending(producer.localId),
1223-
'producer @close event'
1224-
)
1219+
.push(async () => {
1220+
await this._handler.stopSending(producer.localId);
1221+
}, 'producer @close event')
12251222
.catch((error: Error) =>
1226-
logger.warn('producer.close() failed:%o', error)
1223+
logger.warn('producer closure failed:%o', error)
12271224
);
12281225
});
12291226

12301227
producer.on('@pause', (callback, errback) => {
12311228
this._awaitQueue
1232-
.push(
1233-
async () => await this._handler.pauseSending(producer.localId),
1234-
'producer @pause event'
1235-
)
1229+
.push(async () => {
1230+
await this._handler.pauseSending(producer.localId);
1231+
}, 'producer @pause event')
12361232
.then(callback)
12371233
.catch(errback);
12381234
});
12391235

12401236
producer.on('@resume', (callback, errback) => {
12411237
this._awaitQueue
1242-
.push(
1243-
async () => await this._handler.resumeSending(producer.localId),
1244-
'producer @resume event'
1245-
)
1238+
.push(async () => {
1239+
await this._handler.resumeSending(producer.localId);
1240+
}, 'producer @resume event')
12461241
.then(callback)
12471242
.catch(errback);
12481243
});
12491244

12501245
producer.on('@replacetrack', (track, callback, errback) => {
12511246
this._awaitQueue
1252-
.push(
1253-
async () => await this._handler.replaceTrack(producer.localId, track),
1254-
'producer @replacetrack event'
1255-
)
1247+
.push(async () => {
1248+
await this._handler.replaceTrack(producer.localId, track);
1249+
}, 'producer @replacetrack event')
12561250
.then(callback)
12571251
.catch(errback);
12581252
});
12591253

12601254
producer.on('@setmaxspatiallayer', (spatialLayer, callback, errback) => {
12611255
this._awaitQueue
1262-
.push(
1263-
async () =>
1264-
await this._handler.setMaxSpatialLayer(
1265-
producer.localId,
1266-
spatialLayer
1267-
),
1268-
'producer @setmaxspatiallayer event'
1269-
)
1256+
.push(async () => {
1257+
await this._handler.setMaxSpatialLayer(
1258+
producer.localId,
1259+
spatialLayer
1260+
);
1261+
}, 'producer @setmaxspatiallayer event')
12701262
.then(callback)
12711263
.catch(errback);
12721264
});
12731265

12741266
producer.on('@setrtpencodingparameters', (params, callback, errback) => {
12751267
this._awaitQueue
1276-
.push(
1277-
async () =>
1278-
await this._handler.setRtpEncodingParameters(
1279-
producer.localId,
1280-
params
1281-
),
1282-
'producer @setrtpencodingparameters event'
1283-
)
1268+
.push(async () => {
1269+
await this._handler.setRtpEncodingParameters(
1270+
producer.localId,
1271+
params
1272+
);
1273+
}, 'producer @setrtpencodingparameters event')
12841274
.then(callback)
12851275
.catch(errback);
12861276
});

0 commit comments

Comments
 (0)