Skip to content

Commit abafd0b

Browse files
committed
only replace version in transpiled JS during release
1 parent be4e423 commit abafd0b

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

npm-scripts.mjs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ async function run() {
5454
// So here we compile TypeScript to JavaScript.
5555
case 'prepare': {
5656
buildTypescript({ force: false });
57-
replaceVersion();
5857

5958
break;
6059
}
@@ -67,7 +66,6 @@ async function run() {
6766

6867
case 'typescript:build': {
6968
buildTypescript({ force: true, args: taskArgs });
70-
replaceVersion();
7169

7270
break;
7371
}
@@ -91,14 +89,12 @@ async function run() {
9189
}
9290

9391
case 'test': {
94-
replaceVersion();
9592
test();
9693

9794
break;
9895
}
9996

10097
case 'coverage': {
101-
replaceVersion();
10298
coverage({ args: taskArgs });
10399

104100
break;
@@ -283,7 +279,6 @@ function checkRelease() {
283279

284280
installDeps();
285281
buildTypescript({ force: true });
286-
replaceVersion();
287282
lint();
288283
test();
289284
// Validate packaging (the `files` list in package.json) before the
@@ -326,6 +321,9 @@ async function release({ args = '' } = {}) {
326321
// Bump the version in package.json + package-lock.json.
327322
executeCmd(`npm version ${version} --no-git-tag-version`);
328323

324+
// Also replace the version in the transpiled JS.
325+
replaceVersion();
326+
329327
// Commit the bump, tag it, and push both. The pushed tag triggers
330328
// `mediasoup-client-npm-publish.yaml`, which checks, creates the GitHub
331329
// release and publishes to NPM.

0 commit comments

Comments
 (0)