Deprecate coremodules (SYN-8048) (#4188)

Author: Cisphyx

changes/c68703107768a6df0c087c3a0e3e1238.yaml

@@ -0,0 +1,5 @@
+---
+desc: Deprecated the ``modules`` Cortex configuration option.
+prs: []
+type: deprecation
+...

synapse/cortex.py

@@ -815,7 +815,7 @@ class Cortex(s_oauth.OAuthMixin, s_cell.Cell):  # type: ignore
         },
         'modules': {
             'default': [],
-            'description': 'A list of module classes to load.',
+            'description': 'Deprecated. A list of module classes to load.',
             'type': 'array'
         },
         'storm:log': {
@@ -6372,6 +6372,9 @@ async def _preLoadCoreModule(self, ctor, mods, cmds, mdefs, custom=False):
         if isinstance(ctor, (list, tuple)):
             ctor, conf = ctor
 
+        if not ctor.startswith('synapse.tests'):
+            s_common.deprecated("'modules' Cortex config value", curv='2.206.0')
+
         modu = self._loadCoreModule(ctor, conf=conf)
         if modu is None:
             return

synapse/tests/test_cortex.py

@@ -83,6 +83,12 @@ async def test_cortex_basics(self):
 
                 await core.nodes('[ inet:ipv4=1.2.3.4 :asn=99 .seen=now +#foo:score=10 ]')
 
+            conf = {'modules': [('NewpModule', {})]}
+            warn = '''"'modules' Cortex config value" is deprecated'''
+            with self.assertWarnsRegex(DeprecationWarning, warn) as cm:
+                async with self.getTestCore(dirn=dirn) as core:
+                    pass
+
     async def test_cortex_cellguid(self):
         iden = s_common.guid()
         conf = {'cell:guid': iden}