more coverage

Author: rakuy0

synapse/lib/cell.py

@@ -1719,11 +1719,13 @@ async def setDriveInfoPerm(self, iden, perm):
     async def setDriveItemProp(self, iden, path, valu):
         if isinstance(path, str):
             path = (path,)
-        vers, item = await self.getDriveData(iden)
-        if item is None:
+        data = await self.getDriveData(iden)
+        if data is None:
             mesg = f'No drive item with ID {iden}.'
             raise s_exc.NoSuchIden(mesg=mesg)
 
+        vers, item = data
+
         try:
             step = item
             for p in path[:-1]:

synapse/lib/drive.py

@@ -450,6 +450,8 @@ def _getItemData(self, bidn, vers=None):
 
         if vers is None:
             info = self._getItemInfo(bidn)
+            if info is None:
+                return None
             vers = info.get('version')
 
         versindx = getVersIndx(vers)

synapse/tests/test_lib_cell.py

@@ -298,6 +298,8 @@ async def migrate_v1(info, versinfo, data):
                 data = await cell.getDriveData(iden)
                 self.eq(data[1]['stuff'], 3829)
 
+                await self.asyncraises(s_exc.NoSuchIden, cell.setDriveItemProp(s_common.guid(), ('lolnope',), 'not real'))
+
                 await self.asyncraises(s_exc.BadArg, cell.setDriveItemProp(iden, ('blorp', 0, 'neato'), 'my special string'))
                 data[1]['blorp'] = {
                     'bleep': [{'neato': 'thing'}]