From abcde2ac87e7b7dc7f050f1a53a95b632f7230b5 Mon Sep 17 00:00:00 2001 From: epiphyte Date: Fri, 28 Mar 2025 15:55:37 -0400 Subject: [PATCH 1/2] Add permission declarations for queues and light edges (SYN-8959, SYN-8973) --- changes/116c175a74bfbfefae62a705b3d7fe32.yaml | 5 +++++ synapse/cortex.py | 10 ++++++++++ synapse/lib/stormtypes.py | 10 ++++++++++ 3 files changed, 25 insertions(+) create mode 100644 changes/116c175a74bfbfefae62a705b3d7fe32.yaml diff --git a/changes/116c175a74bfbfefae62a705b3d7fe32.yaml b/changes/116c175a74bfbfefae62a705b3d7fe32.yaml new file mode 100644 index 0000000000..16b923fb18 --- /dev/null +++ b/changes/116c175a74bfbfefae62a705b3d7fe32.yaml @@ -0,0 +1,5 @@ +--- +desc: Added missing permission declarations for light edges and queues. +prs: [] +type: bug +... diff --git a/synapse/cortex.py b/synapse/cortex.py index e343a244cd..2c792badc8 100644 --- a/synapse/cortex.py +++ b/synapse/cortex.py @@ -1397,6 +1397,16 @@ def _initCorePerms(self): {'perm': ('node', 'del', '
'), 'gate': 'layer', 'desc': 'Controls removing a specific form of node in a layer.'}, + {'perm': ('node', 'edge', 'add'), 'gate': 'layer', + 'desc': 'Controls adding light edges to a node.'}, + {'perm': ('node', 'edge', 'del'), 'gate': 'layer', + 'desc': 'Controls adding light edges to a node.'}, + + {'perm': ('node', 'edge', 'add', ''), 'gate': 'layer', + 'desc': 'Controls adding a specific light edge to a node.'}, + {'perm': ('node', 'edge', 'del', ''), 'gate': 'layer', + 'desc': 'Controls adding a specific light edge to a node.'}, + {'perm': ('node', 'tag'), 'gate': 'layer', 'desc': 'Controls editing any tag on any node in a layer.'}, {'perm': ('node', 'tag', 'add'), 'gate': 'layer', diff --git a/synapse/lib/stormtypes.py b/synapse/lib/stormtypes.py index ee05d66784..220a72cdd7 100644 --- a/synapse/lib/stormtypes.py +++ b/synapse/lib/stormtypes.py @@ -3933,6 +3933,16 @@ class LibQueue(Lib): 'returns': {'type': 'list', 'desc': 'A list of queue definitions the current user is allowed to interact with.', }}}, ) + _storm_lib_perms = ( + {'perm': ('queue', 'add'), 'gate': 'cortex', + 'desc': 'Permits a user to create a named queue.'}, + {'perm': ('queue', 'get'), 'gate': 'queue', + 'desc': 'Permits a user to access a queue. This allows the user to read from the queue and remove items from it.'}, + {'perm': ('queue', 'put'), 'gate': 'queue', + 'desc': 'Permits a user to put items into a queue.'}, + {'perm': ('cron', 'del'), 'gate': 'queue', + 'desc': 'Permits a user to delete a queue.'}, + ) _storm_lib_path = ('queue',) def getObjLocals(self): From c6c90c1f4d48b5bb6cf0960e396f58e63ce2a096 Mon Sep 17 00:00:00 2001 From: epiphyte Date: Fri, 28 Mar 2025 15:57:25 -0400 Subject: [PATCH 2/2] Fix verb --- synapse/cortex.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/synapse/cortex.py b/synapse/cortex.py index 2c792badc8..cd69ff4e2b 100644 --- a/synapse/cortex.py +++ b/synapse/cortex.py @@ -1402,9 +1402,9 @@ def _initCorePerms(self): {'perm': ('node', 'edge', 'del'), 'gate': 'layer', 'desc': 'Controls adding light edges to a node.'}, - {'perm': ('node', 'edge', 'add', ''), 'gate': 'layer', + {'perm': ('node', 'edge', 'add', ''), 'gate': 'layer', 'desc': 'Controls adding a specific light edge to a node.'}, - {'perm': ('node', 'edge', 'del', ''), 'gate': 'layer', + {'perm': ('node', 'edge', 'del', ''), 'gate': 'layer', 'desc': 'Controls adding a specific light edge to a node.'}, {'perm': ('node', 'tag'), 'gate': 'layer',