Merge pull request #51 from vertti/add-recvcheck-nilnil-linters

Add recvcheck and nilnil linters

Author: vertti

.golangci.yml

@@ -29,6 +29,9 @@ linters:
     - exhaustive     # check exhaustiveness of enum switch statements
     - intrange       # use Go 1.22 range-over-integers
     - copyloopvar    # detect issues with loop variable copying
+    # Consistency
+    - recvcheck      # check receiver type consistency
+    - nilnil         # check for nil,nil returns (excluding intentional cases)
   settings:
     gocritic:
       enabled-tags:

pkg/check/helpers.go

@@ -33,7 +33,7 @@ func (r *Result) AddDetailf(format string, args ...any) *Result {
 // This provides a consistent pattern for optional regex compilation across check packages.
 func CompileRegex(pattern string) (*regexp.Regexp, error) {
 	if pattern == "" {
-		return nil, nil
+		return nil, nil //nolint:nilnil // intentional: empty pattern means "no regex"
 	}
 	return regexp.Compile(pattern)
 }

pkg/check/result.go

@@ -17,6 +17,6 @@ type Result struct {
 }
 
 // OK returns true if the check passed.
-func (r Result) OK() bool {
+func (r *Result) OK() bool {
 	return r.Status == StatusOK
 }

pkg/version/parse.go

@@ -47,7 +47,7 @@ func Parse(s string) (Version, error) {
 func ParseOptional(s string) (*Version, error) {
 	s = strings.TrimSpace(s)
 	if s == "" {
-		return nil, nil
+		return nil, nil //nolint:nilnil // intentional: empty string means "no version constraint"
 	}
 	v, err := Parse(s)
 	if err != nil {