Skip to content

Commit ce34c71

Browse files
authored
Merge pull request #3 from vesavlad/build-fixes
Update build dependencies and some libs in order to make build easy on newer ubuntu
2 parents 336734d + 01ed31d commit ce34c71

17 files changed

Lines changed: 7839 additions & 4801 deletions

File tree

.pkg

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,10 @@
1111
[spdlog]
1212
url=git@github.com:gabime/spdlog.git
1313
branch=master
14-
commit=de0dbfa3596a18cd70a4619b6a9766847a941276
14+
commit=ad0e89cbfb4d0c1ce4d097e134eb7be67baebb36
15+
16+
[zlib]
17+
url=git@github.com:motis-project/zlib.git
18+
branch=master
19+
commit=d1c943390ba4f97aa2f50bedc629b6d29027fa0e
20+

CHANGELOG.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,18 @@ All notable changes to this project will be documented in this file.
1717
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
1818
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
1919

20-
## [Unreleased]
20+
## [2.1.0] - 17-02-2023
21+
### Changed
22+
- Bumped spdlog version
23+
- Bumped buildcache
24+
- Bumped catch2 testing framework used for gtfs lib tests
25+
- fixed building on newer ubuntu compilers
26+
27+
## [2.0.1] - 05-03-2022
28+
### Fixes
29+
- Fixed wrong generation of interpolated times.
30+
31+
## [2.0.0] - 24-01-2021
2132
### Added
2233
- changelog support
2334
- use new dependency management system named [pkg](https://github.com/motis-project/pkg)

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM ubuntu AS builder
1+
FROM ubuntu:jammy AS builder
22

33
WORKDIR /app
44

@@ -18,10 +18,10 @@ RUN mkdir build && \
1818
pwd && \
1919
make install
2020

21-
FROM ubuntu
21+
FROM ubuntu:jammy
2222

2323
RUN apt-get update && \
24-
apt-get install -y libgomp1 && \
24+
apt-get install -y libgomp1 libbz2-dev && \
2525
rm -rf /var/lib/apt/lists/*
2626

2727
COPY --from=builder /usr/local/etc/pfaedle /usr/local/etc/pfaedle

cmake/buildcache.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ else()
2323
message(FATAL "Error: NO_BUILDCACHE was not set but buildcache was not in path and system OS detection failed")
2424
endif()
2525

26-
set(buildcache-url "https://github.com/mbitsnbites/buildcache/releases/download/v0.22.3/${buildcache-archive}")
26+
set(buildcache-url "https://github.com/mbitsnbites/buildcache/releases/download/v0.28.2/${buildcache-archive}")
2727
message(STATUS "Downloading buildcache binary from ${buildcache-url}")
2828
file(DOWNLOAD "${buildcache-url}" ${CMAKE_CURRENT_BINARY_DIR}/${buildcache-archive})
2929
execute_process(

src/apps/pfaedle/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
add_library(pfaedle-main-lib app.cpp)
22
target_link_libraries(pfaedle-main-lib
33
PUBLIC logging
4-
PUBLIC stei-gtfs
4+
PUBLIC gtfs
55
PUBLIC pfaedle-lib
66
PRIVATE pfaedle-generated
77
PRIVATE pfaedle-util

src/libs/gtfs/CMakeLists.txt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
1-
file(GLOB_RECURSE stei-gtfs-src *.cpp)
2-
add_library(stei-gtfs ${stei-gtfs-src})
3-
target_include_directories(stei-gtfs PUBLIC ${CMAKE_CURRENT_LIST_DIR}/include)
1+
cmake_minimum_required(VERSION 3.15 FATAL_ERROR)
42

5-
set_target_properties(stei-gtfs PROPERTIES
3+
file(GLOB_RECURSE gtfs-src ${CMAKE_CURRENT_LIST_DIR}/src/*.cpp)
4+
add_library(gtfs STATIC ${gtfs-src})
5+
6+
target_include_directories(gtfs PUBLIC ${CMAKE_CURRENT_LIST_DIR}/include)
7+
8+
set_target_properties(gtfs PROPERTIES
69
CXX_STANDARD 17
710
CXX_EXTENSIONS OFF)
811

src/libs/gtfs/include/gtfs/stop.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
#include <gtfs/record.h>
33
#include <gtfs/types.h>
44
#include <gtfs/enums/stop_location_type.h>
5-
5+
#include <optional>
66
#include <functional>
77
#include <vector>
88

src/libs/gtfs/include/gtfs/stop_time.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
#include <gtfs/time.h>
66
#include <gtfs/types.h>
77

8+
#include <optional>
89
#include <functional>
910

1011
namespace pfaedle::gtfs

src/libs/gtfs/src/gtfs/access/feed_reader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace pfaedle::gtfs::access
1010
class preparation_handler
1111
{
1212
public:
13-
preparation_handler(feed& f):
13+
explicit preparation_handler(feed& f):
1414
feed_(f)
1515
{
1616
}

src/libs/gtfs/tests/CMakeLists.txt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ set(test_folder_path ${CMAKE_CURRENT_SOURCE_DIR})
22

33
message(STATUS "CMAKE_CURRENT_BINARY_DIR=" ${CMAKE_CURRENT_BINARY_DIR})
44
configure_file(config.h.in ${CMAKE_CURRENT_SOURCE_DIR}/config.h)
5-
add_executable(stei-gtfs-tests
5+
add_executable(gtfs-tests
66
main.cpp
77
time_tests.cpp
88
date_tests.cpp
99
feed_reading.cpp
1010
csv_parsing_tests.cpp
1111
catch_amalgamated.cpp)
1212

13-
target_link_libraries(stei-gtfs-tests PUBLIC stei-gtfs)
14-
target_include_directories(stei-gtfs-tests PRIVATE "${CMAKE_CURRENT_LIST_DIR}/../src/gtfs/access/")
15-
target_compile_features(stei-gtfs-tests PRIVATE cxx_std_17)
16-
add_test("stei-gtfs-tests" stei-gtfs-tests)
13+
target_link_libraries(gtfs-tests PUBLIC gtfs)
14+
target_include_directories(gtfs-tests PRIVATE "${CMAKE_CURRENT_LIST_DIR}/../src/gtfs/access/")
15+
target_compile_features(gtfs-tests PRIVATE cxx_std_17)
16+
add_test("gtfs-tests" gtfs-tests)

0 commit comments

Comments
 (0)