Merge pull request #37184 from vespa-engine/marlon/fix/preview-container

fix(CI): ensure we get a SHA for a container, or fail out if we do not [MERGEOK]

Author: arnej27959

.buildkite/publish-container.sh

@@ -31,6 +31,10 @@ docker push "$VESPA_PREVIEW_CONTAINER_URI"
 
 echo "Signing container image..."
 IMAGE_SHA256=$(crane digest "$VESPA_PREVIEW_CONTAINER_URI")
+if [[ -z "${IMAGE_SHA256}" ]]; then
+    echo "Failed getting IMAGE_SHA256 from ${VESPA_PREVIEW_CONTAINER_URI}"
+    exit 1
+fi
 cosign sign -y --oidc-provider=buildkite-agent "${VESPA_PREVIEW_CONTAINER_URI}@${IMAGE_SHA256}"
 
 echo "Setting Buildkite metadata for Vespa container..."
@@ -42,9 +46,8 @@ SYSTEMTEST_PREVIEW_CONTAINER_URI=docker.io/vespaengine/vespa-systemtest-preview-
 echo "Pushing container: ${SYSTEMTEST_PREVIEW_CONTAINER_URI}"
 docker push "$SYSTEMTEST_PREVIEW_CONTAINER_URI"
 IMAGE_SHA256=$(crane digest "$SYSTEMTEST_PREVIEW_CONTAINER_URI")
-
-if [ "${IMAGE_SHA256}" = "" ]; then
-    echo "Failed getting IMAGE_SHA256 from $SYSTEMTEST_PREVIEW_CONTAINER_URI"
+if [[ -z "${IMAGE_SHA256}" ]]; then
+    echo "Failed getting IMAGE_SHA256 from ${SYSTEMTEST_PREVIEW_CONTAINER_URI}"
     exit 1
 fi