Skip to content

Commit bc6aa3c

Browse files
authored
Merge pull request #36285 from vespa-engine/toregge/run-install-step-before-unit-test-steps
Run install step before unit test steps.
2 parents d1716c9 + 15d01b2 commit bc6aa3c

3 files changed

Lines changed: 43 additions & 8 deletions

File tree

.buildkite/Makefile

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ export VESPA_CONTAINER_IMAGE_VERSION_TAG_SUFFIX ?= -dev-only
4141

4242
.DEFAULT_GOAL := pr
4343

44-
main: build-rpms cpp-test quick-start-guide publish-container publish-artifacts
45-
pr: build-rpms cpp-test basic-search-test
44+
main: cpp-test java-test quick-start-guide publish-container publish-artifacts
45+
pr: basic-search-test
4646

4747
check:
4848
@shellcheck -x $(TOP)/*.sh
@@ -59,19 +59,22 @@ bootstrap-cmake: bootstrap
5959
java: bootstrap
6060
@$(TOP)/execute.sh $@
6161

62+
java-test: install
63+
@$(TOP)/execute.sh $@
64+
6265
cpp: bootstrap-cmake
6366
@$(TOP)/execute.sh $@
6467

65-
cpp-test: cpp
68+
cpp-test: install
6669
@$(TOP)/execute.sh $@
6770

68-
install: cpp java cpp-test
71+
install: cpp java
6972
@$(TOP)/execute.sh $@
7073

7174
build-rpms: install
7275
@$(TOP)/execute.sh $@
7376

74-
basic-search-test: build-rpms
77+
basic-search-test: build-rpms cpp-test java-test
7578
@$(TOP)/execute.sh $@
7679

7780
build-container: build-rpms
@@ -83,10 +86,10 @@ quick-start-guide: build-container
8386
publish-container: build-container
8487
@$(TOP)/execute.sh $@
8588

86-
publish-artifacts: java build-rpms
89+
publish-artifacts: build-rpms
8790
@$(TOP)/execute.sh $@
8891

89-
upload-test-results: java cpp-test
92+
upload-test-results: java-test cpp-test
9093
@$(TOP)/execute.sh $@
9194

9295
.PHONY: \
@@ -96,6 +99,7 @@ upload-test-results: java cpp-test
9699
bootstrap \
97100
bootstrap-cmake \
98101
java \
102+
java-test \
99103
cpp \
100104
cpp-test \
101105
install \

.buildkite/java-test.sh

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
#!/usr/bin/env bash
2+
#
3+
# Copyright Vespa.ai. Licensed under the terms of the Apache 2.0 license. See LICENSE in the project root.
4+
#
5+
# Tests Java components using Maven.
6+
7+
set -o errexit
8+
set -o nounset
9+
set -o pipefail
10+
11+
if [[ -n "${DEBUG:-}" ]]; then
12+
set -o xtrace
13+
fi
14+
15+
mydir=${0%/*}
16+
shlim=${mydir}/show-limits.sh
17+
if [ -x "${shlim}" ]; then
18+
"${shlim}" || echo "failed: ${shlim}"
19+
fi
20+
21+
echo "--- ☕ Testing Java components"
22+
# shellcheck disable=1091
23+
source /etc/profile.d/enable-gcc-toolset.sh
24+
25+
PATH=/opt/vespa-deps/bin:$PATH
26+
27+
cd "$SOURCE_DIR"
28+
29+
echo "Running Maven build with target: verify [threads: ${NUM_MVN_THREADS} opts: ${MAVEN_OPTS:-none} extra-opts: ${VESPA_MAVEN_EXTRA_OPTS:-none}]"
30+
read -ra MVN_EXTRA_OPTS <<< "$VESPA_MAVEN_EXTRA_OPTS"
31+
./mvnw -T "$NUM_MVN_THREADS" "${MVN_EXTRA_OPTS[@]}" verify

.buildkite/java.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ cd "$SOURCE_DIR"
2828

2929
echo "Running Maven build with target: ${VESPA_MAVEN_TARGET} [threads: ${NUM_MVN_THREADS} opts: ${MAVEN_OPTS:-none} extra-opts: ${VESPA_MAVEN_EXTRA_OPTS:-none}]"
3030
read -ra MVN_EXTRA_OPTS <<< "$VESPA_MAVEN_EXTRA_OPTS"
31-
./mvnw -T "$NUM_MVN_THREADS" "${MVN_EXTRA_OPTS[@]}" "$VESPA_MAVEN_TARGET"
31+
./mvnw -T "$NUM_MVN_THREADS" "${MVN_EXTRA_OPTS[@]}" -DskipTests "$VESPA_MAVEN_TARGET"

0 commit comments

Comments
 (0)