Fix capture args by reference in std::ranges to avoid unintended copies

Author: johansolbakken

searchlib/src/vespa/searchlib/expression/and_predicate_node.cpp

@@ -19,10 +19,10 @@ AndPredicateNode::AndPredicateNode(const AndPredicateNode&) = default;
 AndPredicateNode& AndPredicateNode::operator=(const AndPredicateNode&) = default;
 
 bool AndPredicateNode::allow(const DocId docId, const HitRank rank) {
-    return std::ranges::all_of(args(), [docId, rank](auto arg){ return arg->allow(docId, rank); });
+    return std::ranges::all_of(args(), [docId, rank](auto& arg){ return arg->allow(docId, rank); });
 }
 
 bool AndPredicateNode::allow(const document::Document& doc, const HitRank rank) {
-    return std::ranges::all_of(args(), [&doc, rank](auto arg){ return arg->allow(doc, rank); });
+    return std::ranges::all_of(args(), [&doc, rank](auto& arg){ return arg->allow(doc, rank); });
 }
 } // namespace search::expression

searchlib/src/vespa/searchlib/expression/or_predicate_node.cpp

@@ -20,11 +20,11 @@ OrPredicateNode::OrPredicateNode(const OrPredicateNode&) = default;
 OrPredicateNode& OrPredicateNode::operator=(const OrPredicateNode&) = default;
 
 bool OrPredicateNode::allow(const DocId docId, const HitRank rank) {
-    return std::ranges::any_of(args(), [docId, rank](auto arg){ return arg->allow(docId, rank); });
+    return std::ranges::any_of(args(), [docId, rank](auto& arg){ return arg->allow(docId, rank); });
 }
 
 bool OrPredicateNode::allow(const document::Document& doc, const HitRank rank) {
-    return std::ranges::any_of(args(), [&doc, rank](auto arg){ return arg->allow(doc, rank); });
+    return std::ranges::any_of(args(), [&doc, rank](auto& arg){ return arg->allow(doc, rank); });
 }
 
 } // namespace search::expression