ci: fix lint and clippy errors (#842)

* ci: fix lint and clippy errors

updated clippy version has strict check for dead code detection

Signed-off-by: okozachenko1203 <[email protected]>

* fix flake error

Signed-off-by: okozachenko1203 <[email protected]>

* Ignore E203, whitespace before ':'

Currently flake8 gives false positives on the spaces black uses for slices,
which flake8 reports as E203: whitespace before ':'.

Signed-off-by: okozachenko <[email protected]>

* fix lint at mod leve

Signed-off-by: okozachenko1203 <[email protected]>

---------

Signed-off-by: okozachenko1203 <[email protected]>
Signed-off-by: okozachenko <[email protected]>

Author: okozachenko1203

magnum_cluster_api/tests/unit/go_template.py

@@ -381,7 +381,7 @@ def parse_template(self, tmpl_str: str) -> TemplateNode:
 
             # Add text before this expression
             if match.start() > 0:
-                text = tmpl_str[pos : pos + match.start()]
+                text = tmpl_str[pos : pos + match.start()]  # noqa: E203
                 if text:
                     children.append(TextNode(text))
 
@@ -397,9 +397,7 @@ def parse_template(self, tmpl_str: str) -> TemplateNode:
 
                 while depth > 0 and search_pos < len(tmpl_str):
                     next_if = re.search(r"\{\{\s*if\s+", tmpl_str[search_pos:])
-                    next_end = re.search(
-                        r"\{\{\s*end\s*\}\}", tmpl_str[search_pos:]
-                    )
+                    next_end = re.search(r"\{\{\s*end\s*\}\}", tmpl_str[search_pos:])
 
                     if next_end:
                         if next_if and next_if.start() < next_end.start():

src/cluster_api/mod.rs

@@ -1,4 +1,5 @@
 #![allow(clippy::all)]
+#![allow(dead_code)]
 pub mod clusterclasses;
 pub mod clusterresourcesets;
 pub mod clusters;

src/features/admission_plugins.rs

@@ -20,6 +20,7 @@ use kube::CustomResourceExt;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "admissionControlList")]
     pub admission_control_list: String,

src/features/api_server_floating_ip.rs

@@ -20,6 +20,7 @@ use kube::CustomResourceExt;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "apiServerFloatingIP")]
     pub api_server_floating_ip: String,

src/features/api_server_load_balancer.rs

@@ -34,6 +34,7 @@ pub struct APIServerLoadBalancerConfig {
 }
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "apiServerLoadBalancer")]
     pub api_server_load_balancer: APIServerLoadBalancerConfig,

src/features/audit_log.rs

@@ -40,6 +40,7 @@ pub struct AuditLogConfig {
 }
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "auditLog")]
     pub audit_log: AuditLogConfig,

src/features/boot_volume.rs

@@ -30,6 +30,7 @@ pub struct BootVolumeConfig {
 }
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "bootVolume")]
     pub boot_volume: BootVolumeConfig,

src/features/cloud_provider.rs

@@ -14,6 +14,7 @@ use kube::CustomResourceExt;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {}
 
 pub struct Feature {}

src/features/cluster_identity.rs

@@ -22,6 +22,7 @@ use kube::CustomResourceExt;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "clusterIdentityRefName")]
     pub cluster_identity_ref_name: String,

src/features/containerd_config.rs

@@ -29,6 +29,7 @@ use kube::CustomResourceExt;
 use serde::{Deserialize, Serialize};
 
 #[derive(Serialize, Deserialize, ClusterFeatureValues)]
+#[allow(dead_code)]
 pub struct FeatureValues {
     #[serde(rename = "containerdConfig")]
     pub containerd_config: String,