Fix out of bounds columns on lines

vfile · Jul 15, 2024 · 1bddad2 · 1bddad2
1 parent 8ca407a
commit 1bddad2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -65,9 +65,8 @@ export function location(file) {
     ) {
       const offset =
         (point.line > 1 ? indices[point.line - 2] : 0) + point.column - 1
-      // The given `column` could not exist.
-      if (offset > value.length) return
-      return offset
+      // The given `column` could not exist on this line.
+      if (offset < indices[point.line - 1]) return offset
     }
   }
 }

diff --git a/test.js b/test.js
@@ -61,12 +61,19 @@ test('toOffset(point)', async function (t) {
   await t.test(
     'should return `undefined` for out of bounds input (#1)',
     async function () {
-      assert.equal(place.toOffset({line: 3, column: 5}), undefined)
+      assert.equal(place.toOffset({line: 2, column: 5}), undefined)
     }
   )
 
   await t.test(
     'should return `undefined` for out of bounds input (#2)',
+    async function () {
+      assert.equal(place.toOffset({line: 3, column: 5}), undefined)
+    }
+  )
+
+  await t.test(
+    'should return `undefined` for out of bounds input (#3)',
     async function () {
       assert.equal(place.toOffset({line: 4, column: 1}), undefined)
     }