Update .NET version and enhance error handling with custom exceptions (#46)

* Update .NET version in workflow and project files; add custom exceptions for better error handling

* Update macOS version in GitHub Actions workflow to macOS 15

* Remove outdated .NET Core versions from GitHub Actions workflow

* Update Sources/DotNetGraph/Exceptions/CompilationException.cs

Co-authored-by: Lukas Dürrenberger <eXpl0it3r@my-gate.net>

---------

Co-authored-by: Gildas Le Bournault <glebournault@gmail.com>
Co-authored-by: Lukas Dürrenberger <eXpl0it3r@my-gate.net>

Author: 3 people

.github/workflows/dotnet.yml

@@ -16,12 +16,12 @@ jobs:
         platform:
           - { name: Linux, os: ubuntu-22.04 }
           - { name: Windows, os: windows-2022 }
-          - { name: macOS, os: macos-12 }
+          - { name: macOS, os: macos-15 }
         dotnet:
-          - { name: .NET Core 3.1, version: "3.1" }
-          - { name: .NET 5, version: "5.0.x" }
           - { name: .NET 6, version: "6.0.x" }
           - { name: .NET 7, version: "7.0.x" }
+          - { name: .NET 8, version: "8.0.x" }
+          - { name: .NET 9, version: "9.0.x" }
 
     steps:
       - uses: actions/checkout@v3
@@ -36,5 +36,5 @@ jobs:
       - name: Build
         run: dotnet build ./Sources -c Release
       - name: Test
-        if: matrix.dotnet.version == '6.0.x'
+        if: matrix.dotnet.version == '8.0.x'
         run: dotnet test ./Sources -v n --no-restore --no-build -c Release

Sources/DotNetGraph.Tests/DotNetGraph.Tests.csproj

@@ -1,18 +1,18 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
-        <TargetFramework>net6.0</TargetFramework>
+        <TargetFramework>net8.0</TargetFramework>
         <IsPackable>false</IsPackable>
         <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="FluentAssertions" Version="6.11.0"/>
-        <PackageReference Include="MSTest" Version="3.1.1"/>
+        <PackageReference Include="FluentAssertions" Version="7.0.0" />
+        <PackageReference Include="MSTest" Version="3.7.0" />
     </ItemGroup>
 
     <ItemGroup>
-        <ProjectReference Include="..\DotNetGraph\DotNetGraph.csproj"/>
+        <ProjectReference Include="..\DotNetGraph\DotNetGraph.csproj" />
     </ItemGroup>
 
 </Project>

Sources/DotNetGraph/Core/DotEdge.cs

@@ -3,6 +3,7 @@
 using System.Threading.Tasks;
 using DotNetGraph.Attributes;
 using DotNetGraph.Compilation;
+using DotNetGraph.Exceptions;
 
 namespace DotNetGraph.Core
 {
@@ -51,7 +52,7 @@ public DotPointAttribute Pos
         public override async Task CompileAsync(CompilationContext context)
         {
             if (From is null || To is null)
-                throw new Exception("Can't compile edge with null From and/or To");
+                throw new CompilationException("Can't compile edge with null From and/or To");
 
             await context.WriteIndentationAsync();
             await From.CompileAsync(context);

Sources/DotNetGraph/Core/DotElement.cs

@@ -3,6 +3,7 @@
 using System.Threading.Tasks;
 using DotNetGraph.Attributes;
 using DotNetGraph.Compilation;
+using DotNetGraph.Exceptions;
 
 namespace DotNetGraph.Core
 {
@@ -28,27 +29,27 @@ public bool HasAttribute(string name)
         {
             return Attributes.ContainsKey(name);
         }
-        
-        public IDotAttribute GetAttribute(string name)
-        {
-            if (Attributes.TryGetValue(name, out var attribute))
-                return attribute;
-            throw new Exception($"There is no attribute named '{name}'");
-        }
 
-        public IDotAttribute GetAttributeOrDefault(string name, IDotAttribute defaultValue = default)
+                public IDotAttribute GetAttribute(string name)
         {
             if (Attributes.TryGetValue(name, out var attribute))
                 return attribute;
-            return defaultValue;
+            throw new AttributeNotFoundException(name);
         }
 
         public T GetAttribute<T>(string name) where T : IDotAttribute
         {
             var attribute = GetAttribute(name);
             if (attribute is T result)
                 return result;
-            throw new Exception($"Attribute with name '{name}' doesn't match the expected type (expected: {typeof(T)}, current: {attribute.GetType()})");
+            throw new AttributeTypeNotMatchException(name, typeof(T), attribute.GetType());
+        }
+
+                public IDotAttribute GetAttributeOrDefault(string name, IDotAttribute defaultValue = default)
+        {
+            if (Attributes.TryGetValue(name, out var attribute))
+                return attribute;
+            return defaultValue;
         }
 
         public T GetAttributeOrDefault<T>(string name, T defaultValue = default) where T : IDotAttribute
@@ -57,7 +58,7 @@ public T GetAttributeOrDefault<T>(string name, T defaultValue = default) where T
             {
                 if (attribute is T result)
                     return result;
-                throw new Exception($"Attribute with name '{name}' doesn't match the expected type (expected: {typeof(T)}, current: {attribute.GetType()})");
+                throw new AttributeTypeNotMatchException(name, typeof(T), attribute.GetType());
             }
 
             return defaultValue;
@@ -79,7 +80,7 @@ public bool TryGetAttribute(string name, out IDotAttribute attribute)
         public bool TryGetAttribute<T>(string name, out T attribute) where T : IDotAttribute
         {
             var result = TryGetAttribute(name, out var untypedAttribute);
-            if (result is false)
+            if (!result)
             {
                 attribute = default;
                 return false;
@@ -91,7 +92,7 @@ public bool TryGetAttribute<T>(string name, out T attribute) where T : IDotAttri
                 return true;
             }
 
-            throw new Exception($"Attribute with name '{name}' doesn't match the expected type (expected: {typeof(T)}, current: {untypedAttribute.GetType()})");
+            throw new AttributeTypeNotMatchException(name, typeof(T), untypedAttribute.GetType());
         }
 
         public void SetAttribute(string name, IDotAttribute value)

Sources/DotNetGraph/Exceptions/AttributeNotFoundException.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace DotNetGraph.Exceptions
+{
+    public class AttributeNotFoundException : Exception
+    {
+        public AttributeNotFoundException(string attributeName) : base($"There is no attribute named '{attributeName}'")
+        {
+        }
+    }
+}

Sources/DotNetGraph/Exceptions/AttributeTypeNotMatchException.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace DotNetGraph.Exceptions
+{
+    public class AttributeTypeNotMatchException : Exception
+    {
+        public AttributeTypeNotMatchException(string attributeName, Type expectedType, Type currentType) : base($"Attribute with name '{attributeName}' doesn't match the expected type (expected: {expectedType}, current: {currentType})")
+        {
+        }
+    }
+}

Sources/DotNetGraph/Exceptions/CompilationException.cs

@@ -0,0 +1,11 @@
+using System;
+
+namespace DotNetGraph.Exceptions
+{
+    public class CompilationException : Exception
+    {
+        public CompilationException(string compilationError) : base(compilationError)
+        {
+        }
+    }
+}