Breaking changes on v2.5.14

[marpereira]

Hi all!

A breaking change was added on v2.5.14 due to this commit.

Before this change, the input parameter server_relative_url from save_binary and open_binary wasn't escaped and the string must be url escaped (eg. Shared%20Documents for Shared Documents folder).

After this change, the server_relative_url is parsed to Shared%2520Documents due to the urlib.quote method.

We're not expecting this breaking change on a patch version. No matter what, there are no tests covering any error on this change nor a proper warning on the release notes. I think that this is a change that will affect users since office365 uses spaces by default, unfortunately.

[elMonsiEnroute]

perhaps a fix to this would be to first unquote and then quote again? In this scenario, if the string already comes escaped, will not cause further issues.

Something like:
url = quote( unquote(r"{0}/web/getFileByServerRelativePath(DecodedUrl='{1}')/\$value".format( context.service_root_url(), server_relative_url )), safe=":/", )

[mkalinna]

We are also affected by this bug. A fix would be much appreciated!