Fix broken master after merging #1438 and #1437 at the same time.

PetroZarytskyi · vgvassilev · commit 6d35b89371ac · 2025-07-06T19:21:15.000+03:00
This PR addresses 2 problems that arose after that: a mismatch in the signature of a new custom `reverse_forw` and a new tape popping up in a test.
diff --git a/include/clad/Differentiator/STLBuiltins.h b/include/clad/Differentiator/STLBuiltins.h
@@ -729,7 +729,7 @@ template <
     typename It,
     typename ::clad::custom_derivatives::helpers::is_iterator<It>::type = 1>
 clad::ValueAndAdjoint<It, It> operator_plus_plus_reverse_forw(It* it, int,
-                                                              It* d_it, int*) {
+                                                              It* d_it, int) {
   return {++*it, ++*d_it};
 }
 
diff --git a/lib/Differentiator/ReverseModeVisitor.cpp b/lib/Differentiator/ReverseModeVisitor.cpp
@@ -2039,7 +2039,7 @@ Expr* ReverseModeVisitor::getStdInitListSizeExpr(const Expr* E) {
                                   CallArgs, Loc, CUDAExecConfig)
                    .get();
       }
-      if (call->getType()->isVoidType())
+      if (!needsForwPass)
         return StmtDiff(call);
       Expr* callRes = nullptr;
       if (isInsideLoop)

Original file line number	Diff line number	Diff line change
`@@ -729,7 +729,7 @@ template <`
`729`	`729`	`typename It,`
`730`	`730`	`typename ::clad::custom_derivatives::helpers::is_iterator<It>::type = 1>`
`731`	`731`	`clad::ValueAndAdjoint<It, It> operator_plus_plus_reverse_forw(It* it, int,`
`732`		`- It* d_it, int*) {`
	`732`	`+ It* d_it, int) {`
`733`	`733`	`return {++it, ++d_it};`
`734`	`734`	`}`
`735`	`735`
Original file line number	Diff line number	Diff line change
`@@ -2039,7 +2039,7 @@ Expr* ReverseModeVisitor::getStdInitListSizeExpr(const Expr* E) {`
`2039`	`2039`	`CallArgs, Loc, CUDAExecConfig)`
`2040`	`2040`	`.get();`
`2041`	`2041`	`}`
`2042`		`- if (call->getType()->isVoidType())`
	`2042`	`+ if (!needsForwPass)`
`2043`	`2043`	`return StmtDiff(call);`
`2044`	`2044`	`Expr* callRes = nullptr;`
`2045`	`2045`	`if (isInsideLoop)`