Don't consider ref-type VarData in setIsRequired, findReq, getVarDataFromExpr as references are now removed in getIDSequence

Author: PetroZarytskyi

lib/Differentiator/TBRAnalyzer.cpp

@@ -20,15 +20,14 @@ namespace clad {
 
 // NOLINTBEGIN(cppcoreguidelines-pro-type-union-access)
 void TBRAnalyzer::setIsRequired(VarData& varData, bool isReq) {
+  assert(varData.m_Type != VarData::REF_TYPE &&
+         "references should be removed on the getIDSequence stage");
   if (varData.m_Type == VarData::FUND_TYPE)
     varData.m_Val.m_FundData = isReq;
   else if (varData.m_Type == VarData::OBJ_TYPE ||
            varData.m_Type == VarData::ARR_TYPE)
     for (auto& pair : *varData.m_Val.m_ArrData)
       setIsRequired(pair.second, isReq);
-  else if (varData.m_Type == VarData::REF_TYPE && varData.m_Val.m_RefData)
-    if (auto* data = getVarDataFromExpr(varData.m_Val.m_RefData))
-      setIsRequired(*data, isReq);
 }
 
 void TBRAnalyzer::merge(VarData& targetData, VarData& mergeData) {
@@ -73,18 +72,15 @@ TBRAnalyzer::VarData TBRAnalyzer::copy(VarData& copyData) {
 }
 
 bool TBRAnalyzer::findReq(const VarData& varData) {
+  assert(varData.m_Type != VarData::REF_TYPE &&
+         "references should be removed on the getIDSequence stage");
   if (varData.m_Type == VarData::FUND_TYPE)
     return varData.m_Val.m_FundData;
   if (varData.m_Type == VarData::OBJ_TYPE ||
       varData.m_Type == VarData::ARR_TYPE) {
     for (auto& pair : *varData.m_Val.m_ArrData)
       if (findReq(pair.second))
         return true;
-  } else if (varData.m_Type == VarData::REF_TYPE && varData.m_Val.m_RefData) {
-    if (auto* data = getVarDataFromExpr(varData.m_Val.m_RefData)) {
-      if (findReq(*data))
-        return true;
-    }
   }
   return false;
 }
@@ -114,6 +110,8 @@ TBRAnalyzer::VarData* TBRAnalyzer::getVarDataFromExpr(const clang::Expr* E) {
   assert(data && "expression not found");
 
   for (auto it = IDSequence.rbegin(), e = IDSequence.rend(); it != e; ++it) {
+    assert(data->m_Type != VarData::REF_TYPE &&
+           "references should be removed on the getIDSequence stage");
     if (data->m_Type == VarData::OBJ_TYPE) {
       data = &(*data->m_Val.m_ArrData)[*it];
     } else if (data->m_Type == VarData::ARR_TYPE) {
@@ -137,9 +135,6 @@ TBRAnalyzer::VarData* TBRAnalyzer::getVarDataFromExpr(const clang::Expr* E) {
         } else
           data = &foundElem->second;
       }
-    } else if (data->m_Type == VarData::REF_TYPE) {
-      assert(data->m_Val.m_RefData && "undefined m_RefData");
-      data = getVarDataFromExpr(data->m_Val.m_RefData);
     }
   }