Skip to content
This repository was archived by the owner on May 6, 2019. It is now read-only.
This repository was archived by the owner on May 6, 2019. It is now read-only.

Eslint does not pass #68

@sebastiansandqvist

Description

@sebastiansandqvist

If we can get the current code to pass eslint checks, then it can be made a rule that eslint must pass prior to merging a PR.

Most of the current difficulties come from the the jsx-a11y eslint plugin, which does not allow, for example, onClick handlers on static elements like a <span>. In some cases, the css makes it so that a specific element to be used, so these linting rules cannot be easily fixed.

I avoided adding several // eslint-disable-line comments in those cases, since in general those linting suggestions are good and should be addressed in the future.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions