refactor: improve the classes while looking for possible bugs

Author: vianavitor-dev

src/main/java/com/vianavitor/simplelibrarygame/controller/GlobalExceptionHandler.java

@@ -67,4 +67,7 @@ public ResponseEntity<ApiResponse<Void>> handleJWTCreationException(JWTCreationE
         ApiResponse<Void> response = ApiResponse.error(ex.getMessage(), request.getRequestURI());
         return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(response);
     }
+
+//    TODO: handle the JWT token expired exception with a redirection
+//    TODO: handle the IllegalArgumentException in ClassroomService or create another Exception to match the error
 }

src/main/java/com/vianavitor/simplelibrarygame/controller/StudentController.java

@@ -33,6 +33,7 @@ public ResponseEntity<ApiResponse<Student>> register(@Valid @RequestBody Registe
 
         studentService.register(student, request.classroomCode(), request.favoriteGenres());
 
+        // TODO: many to many relationship is creating a loop in the response, fix it
         return ResponseEntity.status(HttpStatus.CREATED)
                 .body(ApiResponse.success(student, "Student registered", req.getRequestURI()));
     }

src/main/java/com/vianavitor/simplelibrarygame/service/ProfessorService.java

@@ -5,6 +5,7 @@
 import com.vianavitor.simplelibrarygame.exception.InvalidOperationException;
 import com.vianavitor.simplelibrarygame.exception.ResourceNotFoundException;
 import com.vianavitor.simplelibrarygame.exception.UserDeactivatedException;
+import com.vianavitor.simplelibrarygame.model.Classroom;
 import com.vianavitor.simplelibrarygame.model.Professor;
 import com.vianavitor.simplelibrarygame.repository.ClassroomRepository;
 import com.vianavitor.simplelibrarygame.repository.ProfessorRepository;
@@ -42,14 +43,14 @@ public Professor register(Professor entity) throws DuplicateResourceException {
     }
 
     public void register(Professor newProfessor, String classroomCode) throws DuplicateResourceException, ResourceNotFoundException {
-        classroomRepository.findByPublicCode(classroomCode)
-                .ifPresentOrElse((classroom ->
-                        newProfessor.getClassrooms().add(classroom)
-                ), () -> {
-                    throw new ResourceNotFoundException("not found classroom");
-                });
-
-        this.register(newProfessor);
+        Classroom classroom = classroomRepository.findByPublicCode(classroomCode)
+                        .orElseThrow(() -> new ResourceNotFoundException("not found classroom"));
+
+        Professor professor = this.register(newProfessor);
+        classroom.getUsers().add(professor);
+
+        classroomRepository.save(classroom);
+//        newProfessor.getClassrooms().add(classroom);
     }
 
     public List<Professor> getAll() {

src/main/java/com/vianavitor/simplelibrarygame/service/StudentService.java

@@ -5,6 +5,7 @@
 import com.vianavitor.simplelibrarygame.exception.InvalidOperationException;
 import com.vianavitor.simplelibrarygame.exception.ResourceNotFoundException;
 import com.vianavitor.simplelibrarygame.exception.UserDeactivatedException;
+import com.vianavitor.simplelibrarygame.model.Classroom;
 import com.vianavitor.simplelibrarygame.model.Genre;
 import com.vianavitor.simplelibrarygame.model.Student;
 import com.vianavitor.simplelibrarygame.model.StudentStats;
@@ -68,20 +69,22 @@ public Student register(Student entity) throws DuplicateResourceException {
     }
 
     public void register(Student newStudent, String classroomCode, Set<Genre> favoriteGenres) throws DuplicateResourceException, ResourceNotFoundException {
-        classroomRepository.findByPublicCode(classroomCode)
-                .ifPresentOrElse((classroom ->
-                        newStudent.getClassrooms().add(classroom)
-                ), () -> {
-                    throw new ResourceNotFoundException("not found classroom");
-                });
+        Classroom classroom = classroomRepository.findByPublicCode(classroomCode)
+                .orElseThrow(() -> new ResourceNotFoundException("not found classroom"));
 
         newStudent.setFavoriteGenre(favoriteGenres);
         Student student = this.register(newStudent);
 
         stats.setUser(student);
+        stats.setLevel(1);
+        stats.setMaxLvlExperience(150);
         stats = statsRepository.save(stats);
 
+        classroom.getUsers().add(student);
+        classroomRepository.save(classroom);
+
         student.setStats(stats);
+        student.getClassrooms().add(classroom);
         repository.save(student);
     }
 

src/main/java/com/vianavitor/simplelibrarygame/service/StudentStatsService.java

@@ -78,6 +78,8 @@ public StudentStats create(Long userId) throws ResourceNotFoundException, Duplic
         }
 
         stats.setUser(student);
+        stats.setLevel(1);
+        stats.setMaxLvlExperience(150);
         stats = repository.save(stats);
 
         student.setStats(stats);