refactor: remove unused login methods

login methods provided by any other class else the AuthenticationController were removed for lack of use

Author: vianavitor-dev

src/main/java/com/vianavitor/simplelibrarygame/controller/AdministratorController.java

@@ -29,13 +29,4 @@ public ResponseEntity<ApiResponse<Administrator>> register(@RequestBody @Valid U
         return ResponseEntity.status(HttpStatus.CREATED)
                 .body(ApiResponse.success(saved, "Administrator registered", req.getRequestURI()));
     }
-
-    @PostMapping("/login")
-    public ResponseEntity<ApiResponse<Long>> login(@RequestBody Map<String, String> credentials, HttpServletRequest request) {
-        String username = credentials.get("username");
-        String password = credentials.get("password");
-        Long userId = administratorService.login(username, password);
-        ApiResponse<Long> response = ApiResponse.success(userId, "Login successful", request.getRequestURI());
-        return ResponseEntity.ok(response);
-    }
 }

src/main/java/com/vianavitor/simplelibrarygame/controller/LibrarianController.java

@@ -26,13 +26,6 @@ public ResponseEntity<ApiResponse<Librarian>> register(@RequestBody Librarian li
         return ResponseEntity.status(HttpStatus.CREATED).body(response);
     }
 
-    @PostMapping("/login")
-    public ResponseEntity<ApiResponse<Long>> login(@RequestBody Map<String, String> credentials, HttpServletRequest request) {
-        Long id = librarianService.login(credentials.get("username"), credentials.get("password"));
-        ApiResponse<Long> response = ApiResponse.success(id, "Login successful", request.getRequestURI());
-        return ResponseEntity.ok(response);
-    }
-
     @GetMapping
     public ResponseEntity<ApiResponse<List<Librarian>>> getAll(HttpServletRequest request) {
         List<Librarian> librarians = librarianService.getAll();

src/main/java/com/vianavitor/simplelibrarygame/controller/ProfessorController.java

@@ -33,12 +33,6 @@ public ResponseEntity<ApiResponse<Professor>> register(@Valid @RequestBody Regis
                 .body(ApiResponse.success(professor, "Professor registered", req.getRequestURI()));
     }
 
-    @PostMapping("/login")
-    public ResponseEntity<ApiResponse<Long>> login(@Valid @RequestBody LoginRequest request, HttpServletRequest req) {
-        Long id = professorService.login(request.username(), request.password());
-        return ResponseEntity.ok(ApiResponse.success(id, "Login successful", req.getRequestURI()));
-    }
-
     @GetMapping
     public ResponseEntity<ApiResponse<List<Professor>>> getAll(HttpServletRequest request) {
         List<Professor> professors = professorService.getAll();

src/main/java/com/vianavitor/simplelibrarygame/controller/StudentController.java

@@ -37,12 +37,6 @@ public ResponseEntity<ApiResponse<Student>> register(@Valid @RequestBody Registe
                 .body(ApiResponse.success(student, "Student registered", req.getRequestURI()));
     }
 
-    @PostMapping("/login")
-    public ResponseEntity<ApiResponse<Long>> login(@Valid @RequestBody LoginRequest request, HttpServletRequest req) {
-        Long id = studentService.login(request.username(), request.password());
-        return ResponseEntity.ok(ApiResponse.success(id, "Login successful", req.getRequestURI()));
-    }
-
     @GetMapping("/{id}/stats")
     public ResponseEntity<ApiResponse<StudentStats>> getStats(@PathVariable Long id, HttpServletRequest request) {
         StudentStats stats = studentService.getStats(id);

src/main/java/com/vianavitor/simplelibrarygame/controller/auth/AuthenticationController.java

@@ -4,6 +4,7 @@
 import com.vianavitor.simplelibrarygame.dto.ApiResponse;
 import com.vianavitor.simplelibrarygame.dto.request.LoginRequest;
 import com.vianavitor.simplelibrarygame.model.utils.classes.User;
+import com.vianavitor.simplelibrarygame.repository.UserRepository;
 import com.vianavitor.simplelibrarygame.service.auth.AuthorizationService;
 import com.vianavitor.simplelibrarygame.service.auth.TokenService;
 import jakarta.servlet.http.HttpServletRequest;
@@ -19,6 +20,8 @@
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
 
+import java.time.LocalDate;
+
 @RestController
 @RequestMapping("/auth")
 public class AuthenticationController {
@@ -31,19 +34,27 @@ public class AuthenticationController {
     @Autowired
     private TokenService tokenService;
 
+    @Autowired
+    private UserRepository repository;
+
     @PostMapping("/login")
     public ResponseEntity<ApiResponse<?>> login(@RequestBody @Valid LoginRequest request, HttpServletRequest req)
             throws JWTCreationException, DisabledException, BadCredentialsException {
         var login = new UsernamePasswordAuthenticationToken(request.username(), request.password());
         var auth = authenticationManager.authenticate(login);
 
-        if (auth.getPrincipal() == null) {
+        User user = (User) auth.getPrincipal();
+
+        if (user == null) {
             return ResponseEntity
                     .internalServerError()
                     .body(ApiResponse.error("missing principal", req.getRequestURI()));
         }
 
-        String token = tokenService.generateToken((User) auth.getPrincipal());
+        user.setLastLogin(LocalDate.now());
+        repository.save(user);
+
+        String token = tokenService.generateToken(user);
         return ResponseEntity.ok(ApiResponse.success(token, "Login successful", req.getRequestURI()));
     }
 }

src/main/java/com/vianavitor/simplelibrarygame/service/AdministratorService.java

@@ -37,30 +37,6 @@ public Administrator register(Administrator entity) {
         return repository.save(entity);
     }
 
-    public Long login(String username, String password) throws InvalidOperationException, UserDeactivatedException{
-        Administrator administrator = (Administrator) repository.findByUsername(username)
-                .orElseThrow(() -> new InvalidOperationException("invalid username or password"));
-
-        boolean invalidPassword = !encoder.matches(password, administrator.getPassword());
-
-        if (invalidPassword) {
-            throw new InvalidOperationException("invalid username or password");
-        }
-
-        boolean wasUserDeactivated = !administrator.isActive();
-        if (wasUserDeactivated) {
-            throw new UserDeactivatedException("this user was deactivated, talk with a administrator or administrador to get more information");
-        }
-
-        // TODO: create JWT Token for authentication
-        // ...
-
-        administrator.setLastLogin(LocalDate.now());
-        repository.save(administrator);
-
-        return administrator.getId();
-    }
-
     @Override
     public void deactivate(Long id) {
         Administrator administrator = repository.findById(id)

src/main/java/com/vianavitor/simplelibrarygame/service/LibrarianService.java

@@ -37,31 +37,6 @@ public Librarian register(Librarian entity) throws DuplicateResourceException {
         return repository.save(entity);
     }
 
-    @Override
-    public Long login(String username, String password) throws InvalidOperationException, UserDeactivatedException{
-        Librarian librarian = (Librarian) repository.findByUsername(username)
-                .orElseThrow(() -> new InvalidOperationException("invalid username or password"));
-
-        boolean invalidPassword = !encoder.matches(password, librarian.getPassword());
-
-        if (invalidPassword) {
-            throw new InvalidOperationException("invalid username or password");
-        }
-
-        boolean wasUserDeactivated = !librarian.isActive();
-        if (wasUserDeactivated) {
-            throw new UserDeactivatedException("this user was deactivated, talk with a professor or administrador to get more information");
-        }
-
-        // TODO: create JWT Token for authentication
-        // ...
-
-        librarian.setLastLogin(LocalDate.now());
-        repository.save(librarian);
-
-        return librarian.getId();
-    }
-
     public List<Librarian> getAll() {
         return (List<Librarian>) repository.findAll();
     }

src/main/java/com/vianavitor/simplelibrarygame/service/ProfessorService.java

@@ -52,31 +52,6 @@ public void register(Professor newProfessor, String classroomCode) throws Duplic
         this.register(newProfessor);
     }
 
-    @Override
-    public Long login(String username, String password) throws InvalidOperationException, UserDeactivatedException {
-        Professor professor = (Professor) repository.findByUsername(username)
-                .orElseThrow(() -> new InvalidOperationException("invalid username or password"));
-
-        boolean invalidPassword = !encoder.matches(password, professor.getPassword());
-
-        if (invalidPassword) {
-            throw new InvalidOperationException("invalid username or password");
-        }
-
-        boolean wasUserDeactivated = !professor.isActive();
-        if (wasUserDeactivated) {
-            throw new UserDeactivatedException("this user was deactivated, talk with a professor or administrador to get more information");
-        }
-
-        // TODO: create JWT Token for authentication
-        // ...
-
-        professor.setLastLogin(LocalDate.now());
-        repository.save(professor);
-
-        return professor.getId();
-    }
-
     public List<Professor> getAll() {
         return (List<Professor>) repository.findAll();
     }

src/main/java/com/vianavitor/simplelibrarygame/service/StudentService.java

@@ -93,31 +93,6 @@ public StudentStats getStats(Long id) throws ResourceNotFoundException {
                 .orElseThrow(() -> new ResourceNotFoundException("not found student stats"));
     }
 
-    @Override
-    public Long login(String username, String password) throws InvalidOperationException, UserDeactivatedException{
-        Student student = (Student) repository.findByUsername(username)
-                .orElseThrow(() -> new InvalidOperationException("invalid username or password"));
-
-        boolean invalidPassword = !encoder.matches(password, student.getPassword());
-
-        if (invalidPassword) {
-            throw new InvalidOperationException("invalid username or password");
-        }
-
-        boolean wasUserDeactivated = !student.isActive();
-        if (wasUserDeactivated) {
-            throw new UserDeactivatedException("this user was deactivated, talk with a professor or administrador to get more information");
-        }
-
-        // TODO: create JWT Token for authentication
-        // ...
-
-        student.setLastLogin(LocalDate.now());
-        repository.save(student);
-
-        return student.getId();
-    }
-
     public List<Student> getAll() {
         return (List<Student>) repository.findAll();
     }

src/main/java/com/vianavitor/simplelibrarygame/service/utils/ManageableUser.java

@@ -6,7 +6,7 @@ public interface ManageableUser<T extends User> {
 
     T register(T entity);
 
-    Long login(String username, String password);
+//    Long login(String username, String password);
 
     void deactivate(Long id);