fix formatting

Author: rcannood

src/main/scala/io/viash/config/arguments/Argument.scala

@@ -19,6 +19,7 @@ package io.viash.config.arguments
 
 import io.circe.Json
 import io.viash.helpers.data_structures._
+import io.viash.helpers.Bash
 import io.viash.schemas._
 import java.nio.file.Paths
 
@@ -82,12 +83,8 @@ abstract class Argument[Type] {
   /** Common parameter name for this argument */
   val par: String = dest + "_" + plainName
 
-  /** Parameter name in bash scripts
-    * For backwards compatibility, meta variables still use uppercase plainName.
-    * Par and dep variables use lowercase plainName for so variables with similar names do not clash.
-    * Examples: VIASH_META_NAME, VIASH_PAR_input, VIASH_DEP_my_dependency
-    */
-  val VIASH_PAR: String = "VIASH_" + dest.toUpperCase + "_" + (if (dest == "meta") plainName.toUpperCase() else plainName)
+  /** Parameter name in bash scripts - see Bash.viashVarName for naming convention */
+  val VIASH_PAR: String = Bash.viashVarName(dest, plainName)
 
   def copyArg(
     `type`: String = this.`type`,

src/main/scala/io/viash/config/dependencies/Dependency.scala

@@ -112,8 +112,8 @@ case class Dependency(
   // So after that step we must always use the righthand object. This makes that much easier.
   def workRepository: Option[Repository] = repository.toOption
 
-  // Name in BashWrapper
-  def VIASH_DEP: String = s"VIASH_DEP_${alias.getOrElse(name).replace("/", "_").toUpperCase()}"
+  // Name in BashWrapper - see Bash.viashVarName for naming convention
+  def VIASH_DEP: String = io.viash.helpers.Bash.viashVarName("dep", alias.getOrElse(name))
   // Name to be used in scripts
   def scriptName: String = alias.getOrElse(name).replace("/", "_")
   // Part of the folder structure where dependencies should be written to, contains the repository & dependency name

src/main/scala/io/viash/helpers/Bash.scala

@@ -76,4 +76,21 @@ object Bash {
       .replaceWith("\\\\\\$VIASH_", "\\$VIASH_", allowUnescape)
       .replaceWith("\\\\\\$\\{VIASH_", "\\${VIASH_", allowUnescape)
   }
-}
+  /**
+    * Generate a VIASH variable name for use in bash scripts.
+    * 
+    * For backwards compatibility, meta variables use uppercase names.
+    * Par and dep variables use lowercase names so variables with similar names
+    * (e.g. "--input" and "--INPUT") do not clash.
+    * 
+    * Examples: VIASH_META_NAME, VIASH_PAR_input, VIASH_DEP_my_dependency
+    *
+    * @param dest The destination type: "par", "meta", or "dep"
+    * @param name The variable name (may contain slashes which are replaced with underscores)
+    * @return The formatted VIASH variable name
+    */
+  def viashVarName(dest: String, name: String): String = {
+    val sanitizedName = name.replace("/", "_")
+    val formattedName = if (dest == "meta") sanitizedName.toUpperCase() else sanitizedName
+    s"VIASH_${dest.toUpperCase()}_$formattedName"
+  }}