Merge pull request #824 from viash-io/port_automatically_convert_integers

`NextflowRunner`: Automatically convert integers to doubles when argument type is `double`

Author: hcannoodt

CHANGELOG.md

@@ -1,6 +1,10 @@
-# Viash 0.x.x (yyyy-MM-dd): TODO Add title
+# Viash 0.9.4 (2025-04-24): Hotfix for Nextflow edge
 
-TODO add summary
+This is a hotfix release for the changes in Nextflow edge's handling of double arguments.
+
+## BUG FIXES
+
+* `NextflowRunner`: Automatically convert integers to doubles when argument type is `double` (port of PR #823, PR #824).
 
 # Viash 0.9.3 (2025-03-31): Support upcoming version of Nextflow
 
@@ -212,6 +216,28 @@ Implemented a proper way of caching dependency repositories. The cache is stored
 
 * `viash test`: Fix an issue where the tests would not copy package config settings to determine the docker image name (PR #767).
 
+# Viash 0.8.8 (2025-04-24): Hotfix for Nextflow edge
+
+This is a hotfix release for the changes in Nextflow edge's handling of double arguments.
+
+## BUG FIXES
+
+* `NextflowRunner`: Automatically convert integers to doubles when argument type is `double` (PR #823).
+
+# Viash 0.8.7 (2025-04-01): Backport support upcoming version of Nextflow
+
+The upcoming release of Nextflow introduces a new class for loading scripts and renamed the old class.
+This release supports this change by using reflection to detect the available class.
+
+## BUG FIXES
+
+* `viash build`: Fix error handling of non-generic errors in the build process or while pushing docker containers (PR #696).
+
+* `NextflowRunner`: ScriptParser was renamed to ScriptLoaderV1 in Nextflow 25.02.0-edge (PR #817). Backport from Viash 0.9.3 (PR #812).
+  This fix uses reflection to detect whether ScriptParser exists -- if not the ScriptLoaderFactory is used instead.
+
+* `NextflowRunner`: Backport path handling for `meta.resources_dir` for when symlinks are used (PR #817).
+
 # Viash 0.8.6 (2024-04-26): Bug fixes and improvements for CI
 
 Fix some issues in some edge cases.

build.sbt

@@ -1,6 +1,6 @@
 name := "viash"
 
-version := "0.9.4-dev"
+version := "0.9.4"
 
 scalaVersion := "3.3.4"
 

src/main/resources/io/viash/runners/nextflow/arguments/_checkArgumentType.nf

@@ -66,64 +66,56 @@ def _checkArgumentType(String stage, Map par, Object value, String errorIdentifi
       foundClass = "List[${e.foundClass}]"
     }
   } else if (par.type == "string") {
-    // cast to string if need be
+    // cast to string if need be. only cast if the value is a GString
     if (value instanceof GString) {
-      value = value.toString()
+      value = value as String
     }
     expectedClass = value instanceof String ? null : "String"
   } else if (par.type == "integer") {
     // cast to integer if need be
-    if (value instanceof String) {
+    if (value !instanceof Integer) {
       try {
-        value = value.toInteger()
+        value = value as Integer
       } catch (NumberFormatException e) {
-        // do nothing
+        expectedClass = "Integer"
       }
     }
-    if (value instanceof java.math.BigInteger) {
-      value = value.intValue()
-    }
-    expectedClass = value instanceof Integer ? null : "Integer"
   } else if (par.type == "long") {
     // cast to long if need be
-    if (value instanceof String) {
+    if (value !instanceof Long) {
       try {
-        value = value.toLong()
+        value = value as Long
       } catch (NumberFormatException e) {
-        // do nothing
+        expectedClass = "Long"
       }
     }
-    if (value instanceof Integer) {
-      value = value.toLong()
-    }
-    expectedClass = value instanceof Long ? null : "Long"
   } else if (par.type == "double") {
     // cast to double if need be
-    if (value instanceof String) {
+    if (value !instanceof Double) {
       try {
-        value = value.toDouble()
+        value = value as Double
       } catch (NumberFormatException e) {
-        // do nothing
+        expectedClass = "Double"
       }
     }
-    if (value instanceof java.math.BigDecimal) {
-      value = value.doubleValue()
-    }
-    if (value instanceof Float) {
-      value = value.toDouble()
+  } else if (par.type == "float") {
+    // cast to float if need be
+    if (value !instanceof Float) {
+      try {
+        value = value as Float
+      } catch (NumberFormatException e) {
+        expectedClass = "Float"
+      }
     }
-    expectedClass = value instanceof Double ? null : "Double"
   } else if (par.type == "boolean" | par.type == "boolean_true" | par.type == "boolean_false") {
     // cast to boolean if need be
-    if (value instanceof String) {
-      def valueLower = value.toLowerCase()
-      if (valueLower == "true") {
-        value = true
-      } else if (valueLower == "false") {
-        value = false
+    if (value !instanceof Boolean) {
+      try {
+        value = value as Boolean
+      } catch (Exception e) {
+        expectedClass = "Boolean"
       }
     }
-    expectedClass = value instanceof Boolean ? null : "Boolean"
   } else if (par.type == "file" && (par.direction == "input" || stage == "output")) {
     // cast to path if need be
     if (value instanceof String) {
@@ -135,10 +127,13 @@ def _checkArgumentType(String stage, Map par, Object value, String errorIdentifi
     expectedClass = value instanceof Path ? null : "Path"
   } else if (par.type == "file" && stage == "input" && par.direction == "output") {
     // cast to string if need be
-    if (value instanceof GString) {
-      value = value.toString()
+    if (value !instanceof String) {
+      try {
+        value = value as String
+      } catch (Exception e) {
+        expectedClass = "String"
+      }
     }
-    expectedClass = value instanceof String ? null : "String"
   } else {
     // didn't find a match for par.type
     expectedClass = par.type

src/test/resources/testnextflowvdsl3/src/integer_as_double/config.vsh.yaml

@@ -0,0 +1,25 @@
+functionality:
+  name: integer_as_double
+  arguments:
+    - name: "--input"
+      type: file
+      required: true
+      example: input.txt
+    - name: "--output"
+      type: file
+      required: true
+      direction: output
+      example: output.txt
+    - name: "--double"
+      type: double
+      required: true
+      direction: input
+      example: 10.5
+  resources:
+    - type: bash_script
+      path: script.sh
+platforms:
+  - type: native
+  - type: docker
+    image: nextflow/bash:latest
+  - type: nextflow

src/test/resources/testnextflowvdsl3/src/integer_as_double/script.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+
+## VIASH START
+par_input='resources/lines3.txt'
+par_double='10.5'
+par_output='output.txt'
+## VIASH END
+
+echo "Copying $par_input to $par_output"
+cp "$par_input" "$par_output"
+
+echo "Adding $par_double to $par_output"
+echo "Double: $par_double" >> "$par_output"
+
+exit 0

src/test/scala/io/viash/runners/nextflow/Vdsl3StandaloneTest.scala

@@ -242,6 +242,46 @@ class Vdsl3StandaloneTest extends AnyFunSuite with BeforeAndAfterAll {
     }
   }
 
+
+  test("Whether integers can be converted to doubles", NextflowTest) {
+    // create params.yaml file
+    val paramsPath = temporaryFolder.resolve("params.yaml")
+    val paramsStr = """id: foo
+      |input: resources/lines3.txt
+      |double: 10
+      |publish_dir: integerAsDouble
+      |""".stripMargin
+    Files.write(paramsPath, paramsStr.getBytes(StandardCharsets.UTF_8))
+
+    val (exitCode, stdOut, stdErr) = NextflowTestHelper.run(
+      mainScript = "target/nextflow/integer_as_double/main.nf",
+      args = Nil,
+      paramsFile = Some(paramsPath.toString()),
+      cwd = tempFolFile
+    )
+
+    assert(exitCode == 0, s"\nexit code was $exitCode\nStd output:\n$stdOut\nStd error:\n$stdErr")
+
+    val expectedFiles =
+      Map(
+        "state" -> "state.yaml",
+        "output" -> "output.txt", 
+      ).map{ case (id, suffix) =>
+        val path = temporaryFolder.resolve("integerAsDouble/foo.integer_as_double." + suffix)
+        (id, path)
+      }
+
+    // check if files exist
+    
+    val src = Source.fromFile(tempFolStr + "/integerAsDouble/foo.integer_as_double.output.txt")
+    try {
+      val moduleOut = src.getLines().mkString(",")
+      assert(moduleOut.equals("one,two,three,Double: 10.0"), s"Expected output 'one,two,three,10.0' but got '$moduleOut'")
+    } finally {
+      src.close()
+    }
+  }
+
   override def afterAll(): Unit = {
     IO.deleteRecursively(temporaryFolder)
   }