Merge pull request #17 from vibe-d/div_by_zero_fix

s-ludwig · web-flow · commit ca0b4c5257cd · 2025-02-13T16:23:54.000+01:00
Fix possible division by zero error in RingBuffer.clear/removeFrontN.
diff --git a/source/vibe/container/ringbuffer.d b/source/vibe/container/ringbuffer.d
@@ -178,6 +178,8 @@ struct RingBuffer(T, size_t N = 0, bool INITIALIZE = true) {
 	void removeFrontN(size_t n)
 	{
 		assert(length >= n);
+		if (!length) return;
+
 		static if (hasElaborateDestructor!T) {
 			foreach (i; 0 .. n)
 				destroy(m_buffer[mod(m_start + i)]);

Original file line number	Diff line number	Diff line change
`@@ -178,6 +178,8 @@ struct RingBuffer(T, size_t N = 0, bool INITIALIZE = true) {`
`178`	`178`	`void removeFrontN(size_t n)`
`179`	`179`	`{`
`180`	`180`	`assert(length >= n);`
	`181`	`+ if (!length) return;`
	`182`	`+`
`181`	`183`	`static if (hasElaborateDestructor!T) {`
`182`	`184`	`foreach (i; 0 .. n)`
`183`	`185`	`destroy(m_buffer[mod(m_start + i)]);`