fix: harden connection manager request cleanup

Author: vicary

deno.json

@@ -4,7 +4,6 @@
   "version": "0.0.0-development",
   "license": "MIT",
   "tasks": {
-    "build": "deno run -A dnt.ts",
     "check": "deno check src/index.ts",
     "dev": "deno run --allow-all src/index.ts",
     "lint": "deno lint",

src/services/connection-manager.test.ts

@@ -1009,6 +1009,32 @@ describe("connection manager", () => {
     );
   });
 
+  it("does not leak active request controllers when callTool throws synchronously", async () => {
+    const manager = new GraphitiConnectionManager({
+      endpoint: "http://test",
+      connectionFactory: () => ({
+        connect: () => Promise.resolve(),
+        close: () => Promise.resolve(),
+        callTool: () => {
+          throw new Error("sync boom");
+        },
+      }),
+    });
+    const internals = manager as unknown as {
+      activeRequestControllers: Set<AbortController>;
+    };
+
+    manager.start();
+    assertEquals(await manager.ready(10), true);
+
+    await assertRejects(
+      () => manager.callTool("search", {}),
+      Error,
+      "sync boom",
+    );
+    assertEquals(internals.activeRequestControllers.size, 0);
+  });
+
   it("rejects invalid non-empty endpoints up front", () => {
     const error = assertThrows(
       () =>

src/services/connection-manager.ts

@@ -491,11 +491,18 @@ export class GraphitiConnectionManager implements GraphitiToolCaller {
     try {
       const controller = new AbortController();
       this.activeRequestControllers.add(controller);
-      return await this.runWithRequestDeadline(
-        this.connection.callTool(
+      let task: Promise<unknown>;
+      try {
+        task = this.connection.callTool(
           { name, arguments: args },
           { signal: controller.signal },
-        ),
+        );
+      } catch (err) {
+        this.activeRequestControllers.delete(controller);
+        throw err;
+      }
+      return await this.runWithRequestDeadline(
+        task,
         deadlineMs,
         controller,
       );