Skip to content

Commit 12dc720

Browse files
committed
chore: follow up review protocol and build compatibility
1 parent 1c4ae81 commit 12dc720

2 files changed

Lines changed: 14 additions & 1 deletion

File tree

docs/ReviewProtocol.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@ request and review feedback needs to be handled systematically.
5151
- If all reviews under a higher-level comment/review wrapper are handled,
5252
hide that umbrella comment with reason `resolved` when GitHub permissions
5353
and tooling allow it.
54+
- If replies were added through a pending personal review, explicitly submit
55+
that review so the comments are visible to reviewers and no replies remain
56+
stuck in `PENDING` state.
5457

5558
6. Re-check live review state.
5659
- Query GitHub again.
@@ -64,6 +67,8 @@ request and review feedback needs to be handled systematically.
6467

6568
8. Request a fresh review.
6669
- Request a new Copilot review on the PR after the fixes are pushed.
70+
- If GitHub rejects the request because you still have a pending review,
71+
submit the pending review first, then retry the fresh-review request.
6772

6873
9. Report status.
6974
- Include:

src/config.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,17 @@ export class ConfigLoadError extends Error {
3535
message: string,
3636
options: { cause?: unknown; code: ConfigLoadErrorCode },
3737
) {
38-
super(message, { cause: options.cause });
38+
super(message);
3939
this.name = "ConfigLoadError";
4040
this.code = options.code;
41+
if (options.cause !== undefined) {
42+
Object.defineProperty(this, "cause", {
43+
value: options.cause,
44+
writable: true,
45+
configurable: true,
46+
enumerable: false,
47+
});
48+
}
4149
}
4250
}
4351

0 commit comments

Comments
 (0)