Notifications: Only show "Silence" button for notification Toasts

Non-notification toasts which are of type Warning or Error cannot
be silenced as they cannot cause an alarm, since only notification
backed toasts can cause alarms.

This commit ensures that the "Silence" button will only be shown
for notification-backed warning/error toasts, and that the normal
"X" (dismiss/close) button is shown for non-notification-backed
toasts.

Contributes to issue #2675

Author: chriadam

components/ToastNotification.qml

@@ -98,13 +98,14 @@ Item {
 				margins: isSilenceButton ? Theme.geometry_toastNotification_label_padding : 0
 			}
 
-			readonly property bool isSilenceButton: root.type === VenusOS.Notification_Warning || root.type === VenusOS.Notification_Alarm
+			readonly property bool isSilenceButton: notificationModelId !== 0 && (root.type === VenusOS.Notification_Warning || root.type === VenusOS.Notification_Alarm)
 			width: isSilenceButton ? silenceLabel.x + silenceLabel.implicitWidth + silenceLabel.anchors.rightMargin
 				: Theme.geometry_toastNotification_minHeight
 			radius: isSilenceButton ? Theme.geometry_button_radius : Theme.geometry_button_border_width
 
 			onClicked: {
-				if (isSilenceButton) {
+				if (notificationModelId !== 0
+						&& (root.type === VenusOS.Notification_Warning || root.type === VenusOS.Notification_Alarm)) {
 					// Silence all similar or lower-level notifications by acknowledging them.
 					// Do NOT acknowledge Info notifications, as they don't buzz, and we
 					// still want the user to see the number of outstanding notifications
@@ -115,13 +116,16 @@ Item {
 					} else {
 						NotificationModel.acknowledgeType(VenusOS.Notification_Warning)
 					}
-				} else {
+				}
+
+				if (root.type === VenusOS.Notification_Info) {
 					// for Info toasts, remove from the toast model (but do NOT acknowledge) all Info toasts.
 					// This ensures that if something generates a hundred Info toasts in a row the user
 					// doesn't have to manually dismiss them all, but can still see the number of
 					// unacknowledged notifications in the Notifications navbar icon bubble number.
 					ToastModel.removeAllInfoExcept(root.toastModelId)
 				}
+
 				root.dismissed()
 			}