-
Notifications
You must be signed in to change notification settings - Fork 7.5k
Open
Labels
needs: triageThis issue needs to be reviewedThis issue needs to be reviewed
Description
Description
In for example a 9:16, subtitles might look like this:
And it's not that they cover the video because otherwise they'd be illegible (which might be defensible I suppose): they're just huge because they only take the height into account when deciding how big to be.
Anyway, I'm only opening this issue because I created a PR to fix the problem a week ago. While this repo's seen a lot of activity I'm not sure if anyone follows there. :-) So please look at videojs/vtt.js#69
Reduced test case
https://codepen.io/Frenzie/pen/qEbjmEO
Steps to reproduce
- Load a vertical video
- Don't use native text track
- Enable captions
Errors
No response
What version of Video.js are you using?
Any, but v8.21.1 and v8.23.4
Video.js plugins used.
No response
What browser(s) including version(s) does this occur with?
All
What OS(es) and version(s) does this occur with?
All
Metadata
Metadata
Assignees
Labels
needs: triageThis issue needs to be reviewedThis issue needs to be reviewed
