Skip to content

Commit 18ac763

Browse files
update notebook
1 parent 5091e2a commit 18ac763

3 files changed

Lines changed: 177 additions & 83 deletions

File tree

examples/gw_eccentricity_demo.ipynb

Lines changed: 131 additions & 60 deletions
Large diffs are not rendered by default.

examples/load_waveform_demo.ipynb

Lines changed: 43 additions & 13 deletions
Large diffs are not rendered by default.

gw_eccentricity/eccDefinition.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,27 +1599,20 @@ def get_approximate_degree_for_rational_fit(self):
15991599
# since the relation between the final degrees and number of
16001600
# cycles is not very simple, and are meant only for a
16011601
# reasonable guess for the initial degrees which is then
1602-
# optimized to get the final degrees.
1603-
# For waveforms containing numerical noise, these numbers may
1604-
# not be even close to the final degrees used for rational
1605-
# fits.
1602+
# adapted to get the final degrees.
16061603

16071604
# assign degree based on the number of extrema if user provided
16081605
# degree is None.
16091606
approximate_num_orbits = max(len(self.pericenters_location),
16101607
len(self.apocenters_location))
1611-
if approximate_num_orbits <= 10:
1612-
num_degree, denom_degree = 2, 2
1613-
elif approximate_num_orbits <= 20:
1608+
if approximate_num_orbits <= 20:
16141609
num_degree, denom_degree = 3, 3
16151610
elif approximate_num_orbits <= 40:
16161611
num_degree, denom_degree = 4, 4
16171612
elif approximate_num_orbits <= 60:
16181613
num_degree, denom_degree = 5, 5
1619-
elif approximate_num_orbits <= 125:
1620-
num_degree, denom_degree = 6, 6
16211614
else:
1622-
num_degree, denom_degree = 7, 7
1615+
num_degree, denom_degree = 6, 6
16231616
return num_degree, denom_degree
16241617

16251618
def check_if_first_derivative_is_not_strictly_monotonic(

0 commit comments

Comments
 (0)