Skip to content

Commit 24bb31f

Browse files
Merge pull request #252 from vijayvarma392/remove_bugs_spin_filter
remove Attribute error when extra_kwargs is None
2 parents b90a896 + 9617eb4 commit 24bb31f

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

gw_eccentricity/eccDefinition.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,12 @@ def __init__(self, dataDict, tref_in=None, fref_in=None,
459459
# oscillations. The details of the filtering procedure are described in
460460
# `spin_filter.py`.
461461
if self.precessing:
462+
# set extra_kwargs to empty dict if it is None to avoid issues when
463+
# trying to access or set keys in extra_kwargs.
464+
if extra_kwargs is None:
465+
extra_kwargs = {}
462466
# set kwargs for filtering.
463-
user_filter_kwargs = extra_kwargs.get(
464-
"filter_kwargs", {}) if extra_kwargs is not None else {}
467+
user_filter_kwargs = extra_kwargs.get("filter_kwargs", {})
465468
filter_kwargs = check_kwargs_and_set_defaults(
466469
user_filter_kwargs,
467470
get_default_kwargs_for_filtering(),

0 commit comments

Comments
 (0)