Skip to content

Commit 4d95905

Browse files
Merge pull request #256 from vijayvarma392/add_filterkwargs_docstring
add filter_kwargs in extra_kwargs doc
2 parents 839bd03 + ed6b597 commit 4d95905

2 files changed

Lines changed: 33 additions & 1 deletion

File tree

gw_eccentricity/eccDefinition.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,22 @@ def __init__(self, dataDict, tref_in=None, fref_in=None,
401401
error in the measured eccentricity and mean anomaly.
402402
See:
403403
https://github.com/vijayvarma392/gw_eccentricity/wiki/Full-waveform-vs-short-segment
404+
405+
filter_kwargs: dict
406+
A dictionary of kwargs to control filtering of spin-induced
407+
oscillations from the waveform data. For spin-precessing
408+
systems, spin-induced oscillations can introduce suborbital scale
409+
oscillations even in the coprecessing frame,
410+
leading to inaccurate eccentricity measurements.
411+
For small eccentricity (below ~1e-2) and high spin-precession,
412+
the spin-induced oscillations may become non-negligible compared
413+
to the eccentric modulations. Filtering them out before
414+
measuring eccentricity helps mitigate this effect.
415+
Only used when `precessing=True`.
416+
Defaults are set using
417+
`spin_filter.get_default_kwargs_for_filtering()`. See
418+
`spin_filter.get_default_kwargs_for_filtering` for the full
419+
list of allowed keys and their descriptions.
404420
"""
405421
# check that only one of tref_in or fref_in is provided
406422
if (tref_in is not None) + (fref_in is not None) != 1:

gw_eccentricity/gw_eccentricity.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,23 @@ def measure_eccentricity(tref_in=None,
508508
decreases the relative error in the measured eccentricity
509509
and mean anomaly. See:
510510
https://github.com/vijayvarma392/gw_eccentricity/wiki/Full-waveform-vs-short-segment
511-
511+
512+
filter_kwargs: dict
513+
A dictionary of kwargs to control filtering of spin-induced
514+
oscillations from the waveform data. For spin-precessing
515+
systems, spin-induced oscillations can introduce suborbital scale
516+
oscillations even in the coprecessing frame, leading to inaccurate
517+
eccentricity measurements.
518+
For small eccentricity (below ~1e-2) and high spin-precession,
519+
the spin-induced oscillations may become non-negligible compared
520+
to the eccentric modulations. Filtering them out
521+
before measuring eccentricity helps mitigate this effect.
522+
Only used when `precessing=True`.
523+
Defaults are set using
524+
`spin_filter.get_default_kwargs_for_filtering()`. See
525+
`spin_filter.get_default_kwargs_for_filtering` for the full
526+
list of allowed keys and their descriptions.
527+
512528
Returns
513529
-------
514530
A dictionary containing the following keys

0 commit comments

Comments
 (0)