I have come across a few possible bugs in the spin filtering code.
eccDefinition line 481: The default value of extra_kwargs is None. As such, if no extra_kwargs is given, this will fail because you cannot assign an element to None. I think it needs a check that extra_kwargs != None as in line 464.
spin_filter: An interpolant of delta_T is constructed over t_mid. However, it is then evaluated across the whole time array, which can include points before the first t_mid, which means that delta_T is then extrapolated and can produce crazy results.
I have come across a few possible bugs in the spin filtering code.
eccDefinition line 481: The default value of extra_kwargs is None. As such, if no extra_kwargs is given, this will fail because you cannot assign an element to None. I think it needs a check that extra_kwargs != None as in line 464.
spin_filter: An interpolant of delta_T is constructed over t_mid. However, it is then evaluated across the whole time array, which can include points before the first t_mid, which means that delta_T is then extrapolated and can produce crazy results.