chore: tweak biome

magne4000 · magne4000 · commit 6c6cd15f8384 · 2025-08-18T11:11:12.000+02:00
diff --git a/.github/actions/bati-run/action.yml b/.github/actions/bati-run/action.yml
@@ -57,9 +57,9 @@ runs:
       run: ${{ runner.os == 'Windows' && 'npm run test' || 'bun turbo run test --only --no-update-notifier --framework-inference false --env-mode loose' }}
       working-directory: ${{ inputs.destination }}
 
-    - name: Run lint
+    - name: Run lint:eslint
       shell: bash
-      run: bun turbo run lint --only --no-update-notifier --framework-inference false --env-mode loose
+      run: bun turbo run lint:eslint --only --no-update-notifier --framework-inference false --env-mode loose
       working-directory: ${{ inputs.destination }}
 
     - name: Run lint:biome
diff --git a/biome.json b/biome.json
@@ -15,40 +15,6 @@
     ]
   },
   "overrides": [
-    {
-      "includes": ["**/*.vue"],
-      "linter": {
-        "domains": {
-          "vue": "recommended"
-        },
-        "rules": {
-          "style": {
-            "useConst": "off",
-            "useImportType": "off"
-          },
-          "correctness": {
-            "noUnusedVariables": "off",
-            "noUnusedImports": "off"
-          }
-        }
-      }
-    },
-    {
-      "includes": ["boilerplates/react", "boilerplates/react-*"],
-      "linter": {
-        "domains": {
-          "react": "recommended"
-        }
-      }
-    },
-    {
-      "includes": ["boilerplates/solid", "boilerplates/solid-*"],
-      "linter": {
-        "domains": {
-          "solid": "recommended"
-        }
-      }
-    },
     {
       "includes": ["packages/**/*.ts", "website/**/*.ts", "website/**/*.tsx"],
       "linter": {
diff --git a/boilerplates/react-sentry/biome.json b/boilerplates/react-sentry/biome.json
@@ -0,0 +1,9 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "react": "recommended"
+    }
+  }
+}
diff --git a/boilerplates/react/biome.json b/boilerplates/react/biome.json
@@ -0,0 +1,9 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "react": "recommended"
+    }
+  }
+}
diff --git a/boilerplates/react/files/layouts/LayoutDefault.tsx b/boilerplates/react/files/layouts/LayoutDefault.tsx
@@ -35,7 +35,6 @@ export default function LayoutDefault({ children }: { children: React.ReactNode
 
 function Sidebar({ children }: { children: React.ReactNode }) {
   return (
-    // biome-ignore lint/correctness/useUniqueElementIds: static id
     <div
       id="sidebar"
       //# BATI.has("tailwindcss")
@@ -66,9 +65,7 @@ function Sidebar({ children }: { children: React.ReactNode }) {
 
 function Content({ children }: { children: React.ReactNode }) {
   return (
-    // biome-ignore lint/correctness/useUniqueElementIds: static id
     <div id="page-container">
-      {/** biome-ignore lint/correctness/useUniqueElementIds: static id */}
       <div
         id="page-content"
         //# BATI.has("tailwindcss")
diff --git a/boilerplates/solid-sentry/biome.json b/boilerplates/solid-sentry/biome.json
@@ -0,0 +1,9 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "solid": "recommended"
+    }
+  }
+}
diff --git a/boilerplates/solid/biome.json b/boilerplates/solid/biome.json
@@ -0,0 +1,9 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "solid": "recommended"
+    }
+  }
+}
diff --git a/boilerplates/vue-sentry/biome.json b/boilerplates/vue-sentry/biome.json
@@ -0,0 +1,19 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "vue": "recommended"
+    },
+    "rules": {
+      "style": {
+        "useConst": "off",
+        "useImportType": "off"
+      },
+      "correctness": {
+        "noUnusedVariables": "off",
+        "noUnusedImports": "off"
+      }
+    }
+  }
+}
diff --git a/boilerplates/vue-sentry/files/sentry.browser.config.ts b/boilerplates/vue-sentry/files/sentry.browser.config.ts
@@ -1,15 +1,14 @@
 import * as Sentry from "@sentry/vue";
-import { usePageContext } from "vike-vue/usePageContext";
+import { getCurrentInstance } from "vue";
 
 export const sentryBrowserConfig = () => {
   // eslint-disable-next-line
   import.meta.env.PROD === true &&
     Sentry.init({
-      // @ts-expect-error
-      app: usePageContext().app,
+      app: getCurrentInstance()?.appContext.app,
       dsn: import.meta.env.PUBLIC_ENV__SENTRY_DSN,
       environment: "production-frontend",
-      //enabled: import.meta.env.DEV ? false : true,
+      // enabled: import.meta.env.DEV ? false : true,
       integrations: [Sentry.replayIntegration()],
       // Set tracesSampleRate to 1.0 to capture 100%
       // of transactions for tracing.
diff --git a/boilerplates/vue/biome.json b/boilerplates/vue/biome.json
@@ -0,0 +1,19 @@
+{
+  "$schema": "../../node_modules/@biomejs/biome/configuration_schema.json",
+  "extends": "//",
+  "linter": {
+    "domains": {
+      "vue": "recommended"
+    },
+    "rules": {
+      "style": {
+        "useConst": "off",
+        "useImportType": "off"
+      },
+      "correctness": {
+        "noUnusedVariables": "off",
+        "noUnusedImports": "off"
+      }
+    }
+  }
+}
diff --git a/packages/tests/src/common.ts b/packages/tests/src/common.ts
@@ -17,8 +17,8 @@ export async function updatePackageJson(
   pkgjson.scripts ??= {};
   pkgjson.scripts.test = "vitest run";
   pkgjson.scripts.knip = "VITE_CJS_IGNORE_WARNING=1 knip";
-  if (pkgjson.scripts.lint?.includes("eslint")) {
-    pkgjson.scripts.lint = pkgjson.scripts.lint.replace("eslint ", "eslint --max-warnings=0 ");
+  if (flags.includes("eslint")) {
+    pkgjson.scripts["lint:eslint"] = "eslint --max-warnings 0 .";
   }
   if (flags.includes("biome")) {
     pkgjson.scripts["lint:biome"] = "biome lint --error-on-warnings";
@@ -83,7 +83,7 @@ export async function createTurboConfig(context: GlobalContext) {
           dependsOn: ["build"],
           env: ["TEST_*"],
         },
-        lint: {
+        "lint:eslint": {
           dependsOn: ["build"],
         },
         "lint:biome": {
diff --git a/packages/tests/src/index.ts b/packages/tests/src/index.ts
@@ -163,7 +163,7 @@ async function execTurborepo(context: GlobalContext, args: mri.Argv<CliOptions>)
 
   await exec(
     npmCli,
-    [...args_1, ...(steps ?? ["build", "test", "lint", "lint:biome", "typecheck", "knip"]), ...args_2],
+    [...args_1, ...(steps ?? ["build", "test", "lint:eslint", "lint:biome", "typecheck", "knip"]), ...args_2],
     {
       timeout: 35 * 60 * 1000, // 35min
       cwd: context.tmpdir,
diff --git a/packages/tests/tests/FRAMEWORK+sentry.spec.ts b/packages/tests/tests/FRAMEWORK+sentry.spec.ts
@@ -58,7 +58,7 @@ await describeBati(({ test, expect, testMatch }) => {
         expect(existsSync(filePath)).toBe(true);
         const content = readFileSync(filePath, { encoding: "utf-8" });
         expect(content).toContain(`from "@sentry/vue"`);
-        expect(content).toContain(`app: usePageContext().app`);
+        expect(content).toContain(`app: getCurrentInstance()`);
       }
       {
         const filePath = path.join(process.cwd(), "layouts", "LayoutDefault.vue");
