Merge pull request #17 from tejaswiMinnu/main

new changes

Author: vikeshi26

.github/workflows/src/arm-modeling-review/detect-arm-leases.js

@@ -1,4 +1,4 @@
-import { resolve } from "path";
+import { join } from "path";
 import { Temporal } from "@js-temporal/polyfill";
 import yaml from "js-yaml";
 import { simpleGit } from "simple-git";
@@ -43,9 +43,9 @@ const leaseSchema = z.object({
  */
 function buildLeaseRelativePath(orgName, rpNamespace, serviceName = "") {
   if (serviceName) {
-    return resolve(".github", "arm-leases", orgName, rpNamespace, serviceName, "lease.yaml");
+    return join(".github", "arm-leases", orgName, rpNamespace, serviceName, "lease.yaml");
   }
-  return resolve(".github", "arm-leases", orgName, rpNamespace, "lease.yaml");
+  return join(".github", "arm-leases", orgName, rpNamespace, "lease.yaml");
 }
 
 /**

.github/workflows/test/arm-modeling-review/detect-arm-leases.test.js

@@ -1,5 +1,5 @@
 import { Temporal } from "@js-temporal/polyfill";
-import { resolve } from "path";
+import { join } from "path";
 import { afterAll, afterEach, beforeAll, describe, expect, it, vi } from "vitest";
 
 /** @type {{ show: import("vitest").MockedFunction<() => Promise<string>>, fetch: import("vitest").MockedFunction<() => Promise<void>> }} */
@@ -170,7 +170,7 @@ describe("detect-arm-leases", () => {
 
       expect(result).toBe(true);
       expect(mockGitInstance.show).toHaveBeenCalledWith([
-        `HEAD^:${resolve(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZ", "lease.yaml")}`,
+        `HEAD^:${join(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZ", "lease.yaml")}`,
       ]);
     });
 
@@ -181,7 +181,7 @@ describe("detect-arm-leases", () => {
 
       expect(result).toBe(true);
       expect(mockGitInstance.show).toHaveBeenCalledWith([
-        `HEAD^:${resolve(".github", "arm-leases", "xyz", "Microsoft.XYZ", "lease.yaml")}`,
+        `HEAD^:${join(".github", "arm-leases", "xyz", "Microsoft.XYZ", "lease.yaml")}`,
       ]);
     });
 
@@ -203,10 +203,10 @@ describe("detect-arm-leases", () => {
       ]);
       expect(mockGitInstance.show).toHaveBeenCalledTimes(2);
       expect(mockGitInstance.show).toHaveBeenNthCalledWith(1, [
-        `HEAD^:${resolve(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZInsights", "lease.yaml")}`,
+        `HEAD^:${join(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZInsights", "lease.yaml")}`,
       ]);
       expect(mockGitInstance.show).toHaveBeenNthCalledWith(2, [
-        `origin/main:${resolve(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZInsights", "lease.yaml")}`,
+        `origin/main:${join(".github", "arm-leases", "xyz", "Microsoft.XYZ", "XYZInsights", "lease.yaml")}`,
       ]);
     });