Skip to content

Commit e1f4a78

Browse files
committed
Revert "Fix activity bug"
This reverts commit f2f8eeb.
1 parent f2f8eeb commit e1f4a78

File tree

11 files changed

+50
-59
lines changed

11 files changed

+50
-59
lines changed

Diff for: .gitignore

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
client/logs
2424
client/*.log
2525
client/npm-debug.log*
26-
client/.git
27-
client/.gitignore
2826

2927
# Dependency directories
3028
client/node_modules/

Diff for: client/README.md

-21
This file was deleted.

Diff for: client/dist/bundle.js

+12-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: client/src/actions/cardActions.js

+4-5
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,11 @@ export function removeCardMember(card_id, user_id) {
8585
if (!response.ok) {
8686
throw setError(response)
8787
}
88-
return response.json()
8988
})
90-
.then((json) => {
89+
.then(() => {
9190
dispatch(deleteCardMemberSuccess({
9291
card_id: card_id,
93-
member_id: user_id,
94-
activities: json.activities
92+
member_id: user_id
9593
}))
9694
})
9795
.catch(error => {
@@ -132,7 +130,8 @@ export function updateCard(data, card_id) {
132130
}
133131
return response.json()
134132
}).then(json => {
135-
dispatch(updateCardSuccess(json))
133+
const massaged = arrayToObjectByID([json])
134+
dispatch(updateCardSuccess(massaged))
136135
}).catch(error => {
137136
dispatch(updateCardFailure(error))
138137
})

Diff for: client/src/components/ListCard.js

-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ class ListCard extends Component {
4747
const { title, member_ids, description, activities, id } = card
4848
let memberList = ''
4949

50-
console.log('activities', activities)
5150

5251
if (member_ids) {
5352
memberList = member_ids.map(member_id => {

Diff for: client/src/helpers/actionHelpers.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
// export const baseURL = 'https://nameless-beyond-77500.herokuapp.com'
2-
export const baseURL = 'http://localhost:3000'
1+
export const baseURL = 'https://nameless-beyond-77500.herokuapp.com'
32

43
export function arrayToObjectByID(data) {
54
let massaged = {}

Diff for: client/src/helpers/activityHelpers.js

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
// updated card
2+
// object: list, title, description, card, membership
3+
// verb: update, create, destroy
4+
// value: ...
5+
// user: name
6+
17
export function activitySentence(name, verb, object, value) {
28

39

@@ -7,8 +13,8 @@ export function activitySentence(name, verb, object, value) {
713
card: `${name} created this card`
814
},
915
update: {
10-
title: `${name} changed the title to '${value}'`,
11-
description: `${name} changed the description to '${value}'`,
16+
title: `${name} changed the title to ${value}`,
17+
description: `${name} changed the description to ${value}`,
1218
list: `${name} moved the card to ${value}`
1319
},
1420
destroy: {

Diff for: client/src/reducers/authReducer.js

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ function authentication(state = initialState, action) {
3737
return {
3838
...state,
3939
token: null,
40-
isLoggedIn: false,
4140
}
4241
case Actions.CREATE_USER_SUCCESS:
4342
return {

Diff for: client/src/reducers/boardReducer.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,17 @@ export default function board(state = initialState, action) {
2020
}
2121
case Actions.GET_BOARD_SUCCESS:
2222
case Actions.CREATE_BOARD_SUCCESS:
23-
case Actions.UPDATE_BOARD_SUCCESS:
2423
return {
2524
...state,
2625
...data.board,
2726
isFetching: false
2827
}
28+
case Actions.UPDATE_BOARD_SUCCESS:
29+
return {
30+
...state,
31+
isFetching: false,
32+
...data.board,
33+
}
2934
case Actions.GET_BOARD_FAILURE:
3035
case Actions.UPDATE_BOARD_FAILURE:
3136
case Actions.CREATE_BOARD_FAILURE:

Diff for: client/src/reducers/cardReducer.js

+5-8
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export default function cards(state = initialState, action) {
3636
case Actions.UPDATE_CARD_SUCCESS:
3737
return {
3838
...state,
39-
error: {},
39+
error: null,
4040
isFetching: false,
4141
cards: {
4242
...state.cards,
@@ -53,30 +53,27 @@ export default function cards(state = initialState, action) {
5353
case Actions.DELETE_CARD_MEMBER_SUCCESS:
5454
return {
5555
...state,
56-
error: {},
56+
error: null,
5757
isFetching: false,
5858
cards: {
5959
...state.cards,
6060
[data.card_id]: {
6161
...state.cards[data.card_id],
6262
member_ids: state.cards[data.card_id]['member_ids'].filter(member =>
63-
member !== data.member_id),
64-
activities: data.activities
65-
63+
member !== data.member_id)
6664
}
6765
},
6866
}
6967
case Actions.ADD_CARD_MEMBER_SUCCESS:
7068
return {
7169
...state,
72-
error: {},
70+
error: null,
7371
isFetching: false,
7472
cards: {
7573
...state.cards,
7674
[data.card_id]: {
7775
...state.cards[data.card_id],
78-
member_ids: [...state.cards[data.card_id]['member_ids'], data.member_id],
79-
activities: data.activities
76+
member_ids: [...state.cards[data.card_id]['member_ids'], data.member_id]
8077
}
8178
},
8279
}

Diff for: client/src/reducers/userReducer.js

+14-4
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,13 @@ function user(state = initialState, action) {
1313
const data = action.data
1414
switch (action.type) {
1515
case Actions.GET_USER_REQUEST:
16-
case Actions.CREATE_USER_REQUEST:
1716
return {
1817
...state,
1918
isFetching: true,
20-
error: {},
19+
error: null,
20+
...action.data
2121
}
2222
case Actions.GET_USER_FAILURE:
23-
case Actions.CREATE_USER_FAILURE:
24-
2523
return {
2624
...state,
2725
isFetching: false,
@@ -39,13 +37,25 @@ function user(state = initialState, action) {
3937
...state,
4038
users: data.users
4139
}
40+
case Actions.CREATE_USER_REQUEST:
41+
return {
42+
...state,
43+
isFetching: true,
44+
error: {}
45+
}
4246
case Actions.CREATE_USER_SUCCESS:
4347
return {
4448
...state,
4549
isFetching: false,
4650
name: action.data.name,
4751
id: action.data.id
4852
}
53+
case Actions.CREATE_USER_FAILURE:
54+
return {
55+
...state,
56+
isFetching: false,
57+
error: action.data
58+
}
4959
default:
5060
return state
5161
}

0 commit comments

Comments
 (0)