update qualified name

Author: tomas-villagesql

villagesql/schema/descriptor/type_context.cc

@@ -29,6 +29,19 @@
 namespace villagesql {
 
 void TypeContext::resolve_cached_values() {
+  // Build qualified_name_ once: "ext.type" or "ext.type(v1,v2,...)"
+  qualified_name_ = descriptor_->qualified_base_name();
+  if (!key_.parameters().empty()) {
+    qualified_name_ += "(";
+    const char *delim = "";
+    for (const auto &[k, v] : key_.parameters().params()) {
+      qualified_name_ += delim;
+      qualified_name_ += v;
+      delim = ",";
+    }
+    qualified_name_ += ")";
+  }
+
   if (!key_.parameters().empty() && descriptor_->resolve_params() != nullptr) {
     // Variable-length type with parameters: resolve via callback
     const auto &param_map = key_.parameters().params();
@@ -49,7 +62,7 @@ void TypeContext::resolve_cached_values() {
       LogVSQL(WARNING_LEVEL,
               "resolve_params failed for type '%s' (params: %s): %s. "
               "Falling back to descriptor defaults.",
-              descriptor_->qualified_name().c_str(),
+              descriptor_->qualified_base_name().c_str(),
               key_.parameters().str().c_str(), error_msg);
       persisted_length_ = descriptor_->persisted_length();
       max_decode_buffer_length_ = descriptor_->max_decode_buffer_length();

villagesql/schema/descriptor/type_context.h

@@ -228,21 +228,7 @@ class TypeContext {
   const std::string &type_name() const { return descriptor_->type_name(); }
   // Returns "extension_name.type_name" or "extension_name.type_name(v1,v2,...)"
   // when parameters are present (e.g. "vsql_tvector.TVECTOR(3)").
-  // Values are listed in sorted key order, comma-separated.
-  std::string qualified_name() const {
-    if (key_.parameters().empty()) {
-      return descriptor_->qualified_name();
-    }
-    std::string result = descriptor_->qualified_name() + "(";
-    const char *delim = "";
-    for (const auto &entry : key_.parameters().params()) {
-      result += delim;
-      result += entry.second;
-      delim = ",";
-    }
-    result += ")";
-    return result;
-  }
+  const std::string &qualified_name() const { return qualified_name_; }
 
   // Storage characteristics for this type instantiation.
   // For fixed-length types, these are copied from the TypeDescriptor.
@@ -262,7 +248,8 @@ class TypeContext {
   // Key for this TypeContext (used by ExtensionObjectMap)
   TypeContextKey key_;
 
-  // Cached storage characteristics (computed eagerly in constructor)
+  // Cached values (computed eagerly in resolve_cached_values())
+  std::string qualified_name_;
   int64_t persisted_length_{0};
   int64_t max_decode_buffer_length_{0};
 };

villagesql/schema/descriptor/type_descriptor.h

@@ -174,8 +174,10 @@ class TypeDescriptor {
     return key_.extension_version();
   }
 
-  // Returns the fully qualified type name: "extension_name.type_name"
-  std::string qualified_name() const {
+  // Returns the qualified base name: "extension_name.type_name"
+  // Does not include parameters. Use TypeContext::qualified_name() for the
+  // full name including parameters (e.g. "vsql_tvector.TVECTOR(3)").
+  std::string qualified_base_name() const {
     return extension_name() + "." + type_name();
   }