File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -326,10 +326,16 @@ class PT_custom_type : public PT_type {
326326
327327 const CHARSET_INFO *get_charset () const override { return &my_charset_bin; }
328328
329- // TODO(villagesql-beta): figure out the correct implementation for these.
329+ // Custom types delegate storage to their implementation_type, so these
330+ // type-specific attributes don't apply:
331+
332+ // Decimal precision is only meaningful for DECIMAL/FLOAT/DOUBLE/temporal.
330333 const char *get_dec () const override { return nullptr ; }
334+ // Geometry subtype is only meaningful for MYSQL_TYPE_GEOMETRY.
331335 uint get_uint_geom_type () const override { return 0 ; }
336+ // Interval lists are only meaningful for ENUM/SET.
332337 List<String> *get_interval_list () const override { return nullptr ; }
338+ // SERIAL is a special alias for BIGINT UNSIGNED AUTO_INCREMENT UNIQUE.
333339 bool is_serial_type () const override { return false ; }
334340};
335341
You can’t perform that action at this time.
0 commit comments