Skip to content

Commit c1d65b8

Browse files
Complete TODO in pt_custom_type.h (#56)
1 parent 969df14 commit c1d65b8

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

villagesql/types/pt_custom_type.h

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,16 @@ class PT_custom_type : public PT_type {
326326

327327
const CHARSET_INFO *get_charset() const override { return &my_charset_bin; }
328328

329-
// TODO(villagesql-beta): figure out the correct implementation for these.
329+
// Custom types delegate storage to their implementation_type, so these
330+
// type-specific attributes don't apply:
331+
332+
// Decimal precision is only meaningful for DECIMAL/FLOAT/DOUBLE/temporal.
330333
const char *get_dec() const override { return nullptr; }
334+
// Geometry subtype is only meaningful for MYSQL_TYPE_GEOMETRY.
331335
uint get_uint_geom_type() const override { return 0; }
336+
// Interval lists are only meaningful for ENUM/SET.
332337
List<String> *get_interval_list() const override { return nullptr; }
338+
// SERIAL is a special alias for BIGINT UNSIGNED AUTO_INCREMENT UNIQUE.
333339
bool is_serial_type() const override { return false; }
334340
};
335341

0 commit comments

Comments
 (0)