review comments

Author: tomas-villagesql

mysql-test/suite/villagesql/create_table/r/create_table_complex_functional_index.result

@@ -52,3 +52,31 @@ id
 100002
 100003
 DROP TABLE t1;
+include/rpl/deprecated/show_binlog_events.inc
+Log_name	Pos	Event_type	Server_id	End_log_pos	Info
+#	#	Query	#	#	use `test`; CREATE TABLE `t1` (
+  `id` int NOT NULL,
+  `sig` vsql_complex.COMPLEX DEFAULT NULL,
+  PRIMARY KEY (`id`),
+  KEY `idx_magnitude` ((vsql_complex.complex_abs(`sig`)))
+)
+#	#	Query	#	#	BEGIN
+#	#	Table_map	#	#	table_id: # (test.t1)
+#	#	Write_rows	#	#	table_id: #
+#	#	Write_rows	#	#	table_id: #
+#	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+#	#	Xid	#	#	COMMIT /* XID */
+#	#	Query	#	#	BEGIN
+#	#	Table_map	#	#	table_id: # (test.t1)
+#	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+#	#	Xid	#	#	COMMIT /* XID */
+#	#	Query	#	#	BEGIN
+#	#	Table_map	#	#	table_id: # (test.t1)
+#	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+#	#	Xid	#	#	COMMIT /* XID */
+#	#	Query	#	#	BEGIN
+#	#	Table_map	#	#	table_id: # (test.t1)
+#	#	Write_rows	#	#	table_id: # flags: STMT_END_F
+#	#	Xid	#	#	COMMIT /* XID */
+#	#	Query	#	#	use `test`; ANALYZE TABLE t1
+#	#	Query	#	#	use `test`; DROP TABLE `t1` /* generated by server */

mysql-test/suite/villagesql/create_table/t/create_table_complex_functional_index.test

@@ -2,6 +2,7 @@
 # Tests indexing computed COMPLEX values
 
 --source include/villagesql/install_complex_extension.inc
+--source include/villagesql/binlog_check_begin.inc
 
 CREATE TABLE t1 (
     id INT PRIMARY KEY,
@@ -14,7 +15,7 @@ SELECT TABLE_NAME, INDEX_NAME, COLUMN_NAME, EXPRESSION
 FROM INFORMATION_SCHEMA.STATISTICS
 WHERE TABLE_NAME = 't1' AND INDEX_NAME = 'idx_magnitude';
 
-# Create a 1000 row dataset to trigger index usage. Max for complex abs less than 20
+# Create a 1000 row dataset to trigger index usage, where we make sure the complex_abs is less than 20
 INSERT INTO t1 (id, sig)
 SELECT
     row_number() OVER () as id,
@@ -48,4 +49,5 @@ SELECT id FROM t1 WHERE vsql_complex.COMPLEX_ABS(sig) > CAST(20.0 AS DOUBLE) ORD
 
 DROP TABLE t1;
 
+--source include/villagesql/binlog_check_end.inc
 --source include/villagesql/uninstall_complex_extension.inc

villagesql/types/util.cc

@@ -1112,12 +1112,7 @@ bool ValidateAndConvertVDFArguments(THD *thd, const char *func_name,
           continue;
         }
       }
-      // Column has no custom type context - reject it
-      villagesql_error(
-          "Cannot initialize function '%s': argument %u must be a custom type "
-          "or string constant",
-          MYF(0), func_name, i + 1);
-      return true;
+      // Column has no custom type context - fall through
     }
 
     // Case 4: Argument is not a custom type and not a constant string