auto-ttl: Add galaxy-level TTL config #76
Merged
+406
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiosalvatore
approved these changes
Dec 4, 2025
galaxycache.go
Outdated
| } | ||
|
|
||
| // WithGetTTL allows the client to specify a default TTL for the galaxy, with optional jitter | ||
| // jitter may be 0 to always set the TTL to exactly ttl in the future after calling the BackendGetter. |
There was a problem hiding this comment.
This sentence seems to be worded strangely... (Same on L547)
Author
There was a problem hiding this comment.
Following our in-person discussion, I've rewritten the semantics to only jitter to earlier-times, and rewritten/expanded these doc-comments. (and updated the package-level doc and a mention in the top-level README -- that needs a more general update that I'll try to get to after the current project is done)
I also moved WithPeekTTL into the PeekPeerCfg struct.
dfinkel
force-pushed
the
galaxy_ttl_config
branch
from
7a88c7e to
0a10226
Compare
galaxycache.go
Outdated
| // | ||
| // Expiration times of values with an expiration earlier than maxTTL in the | ||
| // future are left alone no matter the source. (e.g. the value may have | ||
| // originally had a TTL in the same range, but have been sitting in the cache |
There was a problem hiding this comment.
I'm not sure I'm following here...
Author
There was a problem hiding this comment.
I've done a little rewording. Hopefully that helps?
galaxycache.go
Outdated
Comment on lines
459
to
461
| // When used, Jitter values should be large enough that over a reasonable | ||
| // number of maxTTL intervals, keys that are continually accessed will be | ||
| // spread their expiration across the entire interval. |
There was a problem hiding this comment.
Suggested change
| // When used, Jitter values should be large enough that over a reasonable | |
| // number of maxTTL intervals, keys that are continually accessed will be | |
| // spread their expiration across the entire interval. | |
| // When used, Jitter values should be large enough that, over a reasonable | |
| // number of maxTTL intervals, keys that are continually accessed will | |
| // spread their expiration across the entire interval. |
galaxycache.go
Outdated
| // Negative TTLs and jitter values are silently ignored, and jitter values that | ||
| // are greater than maxTTL will be capped at maxTTL. | ||
| PeekedValueMaxTTL time.Duration `dialsdesc:"max time in the future to allow a value pulled in via a Peek request have their expiration"` | ||
| PeekedValueTTLJitter time.Duration `dialsdesc:"max time to reduce the "` |
galaxycache.go
Outdated
Comment on lines
598
to
600
| // When used, Jitter values should be large enough that over a reasonable | ||
| // number of maxTTL intervals, keys that are continually accessed will be | ||
| // spread their expiration across the entire interval. |
There was a problem hiding this comment.
Suggested change
| // When used, Jitter values should be large enough that over a reasonable | |
| // number of maxTTL intervals, keys that are continually accessed will be | |
| // spread their expiration across the entire interval. | |
| // When used, Jitter values should be large enough that, over a reasonable | |
| // number of maxTTL intervals, keys that are continually accessed will | |
| // spread their expiration across the entire interval. |
dfinkel
force-pushed
the
galaxy_ttl_config
branch
from
0a10226 to
3ede1a3
Compare
Directly support jittering the TTL/expiry to make it easy to do the right thing. (bound the expiration as necessary)
dfinkel
force-pushed
the
galaxy_ttl_config
branch
from
3ede1a3 to
bf29e3b
Compare
sergiosalvatore
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directly support jittering the TTL/expiry to make it easy to do the
right thing. (bound the expiration as necessary)