Skip to content

Commit c3fdc81

Browse files
committed
Don't swallow build failures
Removes try/catch so that we know if a build fails in CI.
1 parent 700cda2 commit c3fdc81

File tree

1 file changed

+62
-67
lines changed

1 file changed

+62
-67
lines changed

rollup.js

+62-67
Original file line numberDiff line numberDiff line change
@@ -35,75 +35,70 @@ async function generateBundle() {
3535
console.log(new Date().toString());
3636
}
3737

38-
try {
39-
const bundle = await rollup.rollup({
40-
cache,
41-
input: 'src/player.js',
42-
plugins: [
43-
babel(),
44-
commonjs(),
45-
nodeResolve()
46-
]
47-
});
48-
49-
cache = bundle;
50-
51-
let { output } = await bundle.generate({
52-
format: 'umd',
53-
name: 'Vimeo.Player',
54-
sourcemap: true,
55-
sourcemapFile: 'dist/player.js.map',
56-
banner
57-
});
58-
59-
let { code, map } = output[0];
60-
61-
fs.writeFileSync('dist/player.js', `${code}\n//# sourceMappingURL=player.js.map`);
62-
fs.writeFileSync('dist/player.js.map', map.toString());
63-
64-
const size = maxmin(code, code, true).replace(/^(.*? )/, '');
65-
console.log(`Created bundle ${chalk.cyan('player.js')}: ${size}`);
66-
67-
const minified = uglifyJs.minify(code, {
68-
sourceMap: {
69-
content: map,
70-
url: 'dist/player.min.js.map'
71-
},
72-
output: {
73-
preamble: banner
74-
},
75-
mangle: {
76-
reserved: ['Player']
77-
}
78-
});
79-
80-
fs.writeFileSync('dist/player.min.js', minified.code.replace(/\/\/# sourceMappingURL=\S+/, ''));
81-
fs.writeFileSync('dist/player.min.js.map', minified.map);
82-
83-
const minifiedSize = maxmin(code, minified.code, true);
84-
console.log(`Created bundle ${chalk.cyan('player.min.js')}: ${minifiedSize}`);
85-
86-
({ output } = await bundle.generate({
87-
format: 'es',
88-
banner
89-
}));
90-
91-
({ code, map } = output[0]);
92-
93-
fs.writeFileSync('dist/player.es.js', code);
94-
const esSize = maxmin(code, code, true).replace(/^(.*? )/, '');
95-
console.log(`Created bundle ${chalk.cyan('player.es.js')}: ${esSize}`);
96-
97-
building = false;
98-
99-
if (needsRebuild) {
100-
await generateBundle();
38+
const bundle = await rollup.rollup({
39+
cache,
40+
input: 'src/player.js',
41+
plugins: [
42+
babel(),
43+
commonjs(),
44+
nodeResolve()
45+
]
46+
});
47+
48+
cache = bundle;
49+
50+
let { output } = await bundle.generate({
51+
format: 'umd',
52+
name: 'Vimeo.Player',
53+
sourcemap: true,
54+
sourcemapFile: 'dist/player.js.map',
55+
banner
56+
});
57+
58+
let { code, map } = output[0];
59+
60+
fs.writeFileSync('dist/player.js', `${code}\n//# sourceMappingURL=player.js.map`);
61+
fs.writeFileSync('dist/player.js.map', map.toString());
62+
63+
const size = maxmin(code, code, true).replace(/^(.*? )/, '');
64+
console.log(`Created bundle ${chalk.cyan('player.js')}: ${size}`);
65+
66+
const minified = uglifyJs.minify(code, {
67+
sourceMap: {
68+
content: map,
69+
url: 'dist/player.min.js.map'
70+
},
71+
output: {
72+
preamble: banner
73+
},
74+
mangle: {
75+
reserved: ['Player']
10176
}
77+
});
10278

103-
} catch(error) {
104-
console.log(error);
105-
};
106-
};
79+
fs.writeFileSync('dist/player.min.js', minified.code.replace(/\/\/# sourceMappingURL=\S+/, ''));
80+
fs.writeFileSync('dist/player.min.js.map', minified.map);
81+
82+
const minifiedSize = maxmin(code, minified.code, true);
83+
console.log(`Created bundle ${chalk.cyan('player.min.js')}: ${minifiedSize}`);
84+
85+
({ output } = await bundle.generate({
86+
format: 'es',
87+
banner
88+
}));
89+
90+
({ code, map } = output[0]);
91+
92+
fs.writeFileSync('dist/player.es.js', code);
93+
const esSize = maxmin(code, code, true).replace(/^(.*? )/, '');
94+
console.log(`Created bundle ${chalk.cyan('player.es.js')}: ${esSize}`);
95+
96+
building = false;
97+
98+
if (needsRebuild) {
99+
await generateBundle();
100+
}
101+
}
107102

108103
generateBundle();
109104

0 commit comments

Comments
 (0)