Some optimizations in SceneGraph code (aframevr#809)

* Break the for loop when entity is found in SceneGraph selectEntity

* Simplify getting visible property, it's okay to always use entity.object3D.visible

* No need to uppercase entity.tagName

Author: vincentfretin

src/components/scenegraph/Entity.js

@@ -33,10 +33,7 @@ export default class Entity extends React.Component {
 
   toggleVisibility = () => {
     const entity = this.props.entity;
-    const visible =
-      entity.tagName.toLowerCase() === 'a-scene'
-        ? entity.object3D.visible
-        : entity.getAttribute('visible');
+    const visible = entity.object3D.visible;
     entity.setAttribute('visible', !visible);
   };
 
@@ -92,10 +89,7 @@ export default class Entity extends React.Component {
     }
 
     // Visibility button.
-    const visible =
-      tagName === 'a-scene'
-        ? entity.object3D.visible
-        : entity.getAttribute('visible');
+    const visible = entity.object3D.visible;
     const visibilityButton = (
       <i title="Toggle entity visibility" onClick={this.toggleVisibility}>
         {visible ? (

src/components/scenegraph/SceneGraph.js

@@ -109,6 +109,7 @@ export default class SceneGraph extends React.Component {
         this.expandToRoot(entity);
         Events.emit('entityselect', entity);
         found = true;
+        break;
       }
     }
 
@@ -364,7 +365,7 @@ function filterEntity(entity, filter) {
   // Check if the ID, tagName, class, selector includes the filter.
   if (
     entity.id.toUpperCase().indexOf(filter.toUpperCase()) !== -1 ||
-    entity.tagName.toUpperCase().indexOf(filter.toUpperCase()) !== -1 ||
+    entity.tagName.indexOf(filter.toUpperCase()) !== -1 ||
     entity.classList.contains(filter) ||
     entity.matches(filter)
   ) {