Use const CSVFormat& in calculate_score (#236)

rajgoel · web-flow · commit 5a05e6a85dea · 2024-06-15T12:24:28.000-07:00
Co-authored-by: Asvin Goel &lt;goel@telematique.eu&gt;
diff --git a/include/internal/csv_reader.cpp b/include/internal/csv_reader.cpp
@@ -38,7 +38,7 @@ namespace csv {
             return CSVRow(std::move(rows[format.get_header()]));
         }
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format) {
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format) {
             // Frequency counter of row length
             std::unordered_map<size_t, size_t> row_tally = { { 0, 0 } };
 
diff --git a/include/internal/csv_reader.hpp b/include/internal/csv_reader.hpp
@@ -34,7 +34,7 @@ namespace csv {
             size_t header;
         };
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format);
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format);
 
         CSVGuessResult _guess_format(csv::string_view head, const std::vector<char>& delims = { ',', '|', '\t', ';', '^', '~' });
     }
diff --git a/single_include/csv.hpp b/single_include/csv.hpp
@@ -6238,7 +6238,7 @@ namespace csv {
             size_t header;
         };
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format);
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format);
 
         CSVGuessResult _guess_format(csv::string_view head, const std::vector<char>& delims = { ',', '|', '\t', ';', '^', '~' });
     }
@@ -7359,7 +7359,7 @@ namespace csv {
             return CSVRow(std::move(rows[format.get_header()]));
         }
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format) {
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format) {
             // Frequency counter of row length
             std::unordered_map<size_t, size_t> row_tally = { { 0, 0 } };
 
diff --git a/single_include_test/csv.hpp b/single_include_test/csv.hpp
@@ -6238,7 +6238,7 @@ namespace csv {
             size_t header;
         };
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format);
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format);
 
         CSVGuessResult _guess_format(csv::string_view head, const std::vector<char>& delims = { ',', '|', '\t', ';', '^', '~' });
     }
@@ -7359,7 +7359,7 @@ namespace csv {
             return CSVRow(std::move(rows[format.get_header()]));
         }
 
-        CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format) {
+        CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format) {
             // Frequency counter of row length
             std::unordered_map<size_t, size_t> row_tally = { { 0, 0 } };
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ namespace csv {`
`38`	`38`	`return CSVRow(std::move(rows[format.get_header()]));`
`39`	`39`	`}`
`40`	`40`
`41`		`- CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format) {`
	`41`	`+ CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format) {`
`42`	`42`	`// Frequency counter of row length`
`43`	`43`	`std::unordered_map<size_t, size_t> row_tally = { { 0, 0 } };`
`44`	`44`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ namespace csv {`
`34`	`34`	`size_t header;`
`35`	`35`	`};`
`36`	`36`
`37`		`- CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format);`
	`37`	`+ CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format);`
`38`	`38`
`39`	`39`	`CSVGuessResult _guess_format(csv::string_view head, const std::vector<char>& delims = { ',', '\|', '\t', ';', '^', '~' });`
`40`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6238,7 +6238,7 @@ namespace csv {`
`6238`	`6238`	`size_t header;`
`6239`	`6239`	`};`
`6240`	`6240`
`6241`		`- CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format);`
	`6241`	`+ CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format);`
`6242`	`6242`
`6243`	`6243`	`CSVGuessResult _guess_format(csv::string_view head, const std::vector<char>& delims = { ',', '\|', '\t', ';', '^', '~' });`
`6244`	`6244`	`}`
`@@ -7359,7 +7359,7 @@ namespace csv {`
`7359`	`7359`	`return CSVRow(std::move(rows[format.get_header()]));`
`7360`	`7360`	`}`
`7361`	`7361`
`7362`		`- CSV_INLINE GuessScore calculate_score(csv::string_view head, CSVFormat format) {`
	`7362`	`+ CSV_INLINE GuessScore calculate_score(csv::string_view head, const CSVFormat& format) {`
`7363`	`7363`	`// Frequency counter of row length`
`7364`	`7364`	`std::unordered_map<size_t, size_t> row_tally = { { 0, 0 } };`
`7365`	`7365`