Skip to content

Commit 1f9ffb8

Browse files
committed
Updated the workflow to take directly from repo variables
1 parent 0a275ba commit 1f9ffb8

1 file changed

Lines changed: 12 additions & 18 deletions

File tree

.github/workflows/Code-Quality-check.yml

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,12 @@ permissions:
88
pull-requests: write
99
contents: read
1010
issues: write
11+
checks: write
12+
statuses: write
1113

1214
jobs:
1315
test-and-quality:
1416
runs-on: ubuntu-latest
15-
env:
16-
CLOUD_STORE_GROUP_ID: ${{ vars.CLOUD_STORE_GROUP_ID }}
17-
CLOUD_STORE_ARTIFACT_ID: ${{ vars.CLOUD_STORE_ARTIFACT_ID }}
18-
CLOUD_STORE_VERSION: ${{ vars.CLOUD_STORE_VERSION }}
1917
steps:
2018
- uses: actions/checkout@v3
2119
with:
@@ -38,19 +36,16 @@ jobs:
3836
3937
- name: Build and Run Tests
4038
run: |
41-
echo ${CLOUD_STORE_GROUP_ID}
42-
echo ${CLOUD_STORE_ARTIFACT_ID}
43-
echo ${CLOUD_STORE_VERSION}
44-
mvn clean install -DskipTests \
45-
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
46-
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
47-
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION}
39+
mvn clean install -DskipTests=true \
40+
-DCLOUD_STORE_GROUP_ID=${{ vars.CLOUD_STORE_GROUP_ID }} \
41+
-DCLOUD_STORE_ARTIFACT_ID=${{ vars.CLOUD_STORE_ARTIFACT_ID }} \
42+
-DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }}
4843
echo "Running the test cases"
4944
cd content-api/content-service/
5045
mvn clean test org.jacoco:jacoco-maven-plugin:0.8.8:prepare-agent test org.jacoco:jacoco-maven-plugin:0.8.8:report \
51-
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
52-
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
53-
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION}
46+
-DCLOUD_STORE_GROUP_ID=${{ vars.CLOUD_STORE_GROUP_ID }} \
47+
-DCLOUD_STORE_ARTIFACT_ID=${{ vars.CLOUD_STORE_ARTIFACT_ID }} \
48+
-DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }}
5449
5550
- name: Upload Test Results
5651
if: always()
@@ -76,14 +71,13 @@ jobs:
7671

7772
- name: SonarCloud Analysis
7873
env:
79-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8074
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
8175
working-directory: content-api/content-service
8276
run: |
8377
mvn sonar:sonar \
84-
-DCLOUD_STORE_GROUP_ID=${CLOUD_STORE_GROUP_ID} \
85-
-DCLOUD_STORE_ARTIFACT_ID=${CLOUD_STORE_ARTIFACT_ID} \
86-
-DCLOUD_STORE_VERSION=${CLOUD_STORE_VERSION} \
78+
-DCLOUD_STORE_GROUP_ID=${{ vars.CLOUD_STORE_GROUP_ID }} \
79+
-DCLOUD_STORE_ARTIFACT_ID=${{ vars.CLOUD_STORE_ARTIFACT_ID }} \
80+
-DCLOUD_STORE_VERSION=${{ vars.CLOUD_STORE_VERSION }} \
8781
-Dsonar.projectKey=Sunbird-Knowlg_knowledge-platform \
8882
-Dsonar.organization=sunbird-knowlg-1 \
8983
-Dsonar.host.url=https://sonarcloud.io \

0 commit comments

Comments
 (0)