Debian build instructions incomplete

[probonopd]

I also had to sudo apt install libwlroots-0.18-dev.

Even then, I got

-- setup WLROOTS_VERSION: count 3, major 0, minor 18, patch 0
-- Checking for module 'wlr-protocols'
--   Package 'wlr-protocols', required by 'virtual:world', not found
CMake Error at src/CMakeLists.txt:53 (message):
  wlr-protocols not found, and `DISABLE_WLR_PROTOCOLS` set to OFF!


-- Configuring incomplete, errors occurred!

With cmake -B build -DDISABLE_WLR_PROTOCOLS=1 I get:

In file included from /usr/include/wlroots-0.18/wlr/types/wlr_output.h:18,
                 from /usr/include/wlroots-0.18/wlr/backend.h:13,
                 from /home/user/qwlroots/build/src/qwlroots_autogen/EWIEGA46WW/../../../../src/qwbackend.h:9,
                 from /home/user/qwlroots/build/src/qwlroots_autogen/EWIEGA46WW/moc_qwbackend.cpp:10,
                 from /home/user/qwlroots/build/src/qwlroots_autogen/mocs_compilation.cpp:2:
/usr/include/wlroots-0.18/wlr/types/wlr_buffer.h:171:55: error: expected primary-expression before ‘static’
  171 |         struct wlr_buffer *wlr_buffer, uint32_t color[static 4]);
      |                                                       ^~~~~~
/usr/include/wlroots-0.18/wlr/types/wlr_buffer.h:171:55: error: expected ‘]’ before ‘static’
  171 |         struct wlr_buffer *wlr_buffer, uint32_t color[static 4]);
      |                                                       ^~~~~~
      |                                                       ]
/usr/include/wlroots-0.18/wlr/types/wlr_buffer.h:171:55: error: expected ‘)’ before ‘static’
  171 |         struct wlr_buffer *wlr_buffer, uint32_t color[static 4]);
      |                                                       ^~~~~~
      |                                                       )
/usr/include/wlroots-0.18/wlr/types/wlr_buffer.h:170:47: note: to match this ‘(’
  170 | bool wlr_single_pixel_buffer_color_from_buffer(
      |                                               ^
/usr/include/wlroots-0.18/wlr/types/wlr_buffer.h:171:55: error: expected initializer before ‘static’
  171 |         struct wlr_buffer *wlr_buffer, uint32_t color[static 4]);
      |                                                       ^~~~~~
gmake[2]: *** [src/CMakeFiles/qwlroots.dir/build.make:76: src/CMakeFiles/qwlroots.dir/qwlroots_autogen/mocs_compilation.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:167: src/CMakeFiles/qwlroots.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

How to build on Debian GNU/Linux 12 (bookworm)?

https://github.com/vioken/qwlroots/blob/4880f9a7a820fa15d67c805156a100ac6c402490/debian/control#L10C16-L10C29

This doesn't seem to exist in Debian:

https://packages.debian.org/search?keywords=wlr-protocols&searchon=names&suite=all&section=all

[Dami-star]

On Debian you may need to manually package and compile the wlr-protocols：
https://github.com/deepin-community/wlr-protocols/tree/master

[probonopd]

Thanks, doing that I was able to build this successfully.
It should be put into the build documentation please.

And -DDISABLE_WLR_PROTOCOLS=1 does not work, is it broken? THen it should be removed.

Thank you very much for this useful library.

[zccrs]

Thanks, doing that I was able to build this successfully. It should be put into the build documentation please.

And -DDISABLE_WLR_PROTOCOLS=1 does not work, is it broken? THen it should be removed.

Thank you very much for this useful library.

I'm tested the DISABLE_WLR_PROTOCOLS, it can work on ArchLinux.
For the Debian error, you can test this PR: #314

[probonopd]

I think that it would be best if a GitHub Action could be made for Debian GNU/Linux 12 (bookworm). This way, everyone could see how it is actually compiled on Debian. Thanks for considering!

[zccrs]

I think that it would be best if a GitHub Action could be made for Debian GNU/Linux 12 (bookworm). This way, everyone could see how it is actually compiled on Debian. Thanks for considering!

Good idea, would you like open a PR for the GitHub action?