Skip to content

The Revision Label makes terraform plan think helm release has changes #577

Open
@jay-docusign

Description

@jay-docusign

Describe the Issue
Code adds a .Revision label to everything
https://github.com/virtual-kubelet/azure-aci/blob/master/charts/virtual-kubelet/templates/_helpers.tpl#L25

This results in helm template returning a manifest which has diffs in labels and checksum.

Steps To Reproduce
Example

"virtual-kubelet-test/deployment.apps/apps/v1/virtual-kubelet-release-test-virtual-kubelet-azure-aci"                                                 = {

                  ~ metadata   = {
                      ~ labels    = {
                          ~ revision     = "21" -> "22"
                            # (6 unchanged attributes hidden)
                        }
                        name      = "virtual-kubelet-release-test-virtual-kubelet-azure-aci"
                        # (1 unchanged attribute hidden)
                    }
                  ~ spec       = {
                      ~ template = {
                          ~ metadata = {
                              ~ annotations = {
                                  ~ "checksum/secret" = "7bffddf3d3196ab131293bf3d4a390e339a9df50dadaa64cf6dcc78961ef2142" -> "d1c5fdc3851dbea0e8b748f5dc3fd3fc936811e33592267ba709342714e99fd3"
                                }
                                # (1 unchanged attribute hidden)
                            }
                            # (1 unchanged attribute hidden)
                        }
                        # (2 unchanged attributes hidden)
                    }
                    # (2 unchanged attributes hidden)
                }

Expected behavior
helm template should not show any changes from existing release by default.
Ways to achieve:

  1. Remove Revision label completely
  2. Put Revision label behind a conditional
  3. Allow labels to be modifiable via Values

Virtual-kubelet version
1.6.0

Kubernetes version
1.24

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions