Fix to better handle PowerDNS database connection failures #4
build
/
CI code review
12s
build
/
Package and upload artifacts
59s
Annotations
2 warnings
|
build / CI code review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
build / CI code review:
virtualmin-powerdns-lib.pl#L35
connect_to_database now enables DBI PrintError, which can emit database connection or SQL
errors directly to STDERR/logs and may include operational details such as database names,
hosts, or query context. The submitted change explicitly turns this on while also adding
cleaned user-facing errors, so the extra raw warning output is likely unintended.
Suggested fix:
Use PrintError => 0 and capture RaiseError/eval or driver errstr for controlled, sanitized
reporting instead of allowing DBI to print raw warnings.
|