Skip to content

Commit b1ca5c3

Browse files
committed
Update percetileClosest condition with hardcoded quantiles
1 parent 64f0bc9 commit b1ca5c3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/public/viz-guardrails/LineChart.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,8 @@ export function LineChart({
294294
const percentileClosestData = useMemo(() => {
295295
if (guardrail !== 'percentileClosest') return null;
296296

297-
const quantiles = Array.from({ length: numQuantiles - 1 }, (_, i) => (i + 1) / numQuantiles);
297+
// Hardcoded quantiles for n = 5
298+
const quantiles = [0.05, 0.25, 0.5, 0.75, 0.95];
298299

299300
const groupedByDate = d3.group(data, (d) => d[parameters.x_var]);
300301
const groupedByCountry = d3.group(data, (d) => d[parameters.cat_var]);
@@ -340,7 +341,7 @@ export function LineChart({
340341
quantiles,
341342
closest,
342343
};
343-
}, [data, parameters, guardrail, numQuantiles]);
344+
}, [data, parameters, guardrail]);
344345

345346
// ---------------------------- Cluster Representatives ----------------------------
346347
const [clusterReps, setClusterReps] = useState<any[]>([]);
@@ -964,10 +965,11 @@ export function LineChart({
964965
}
965966
}
966967
if (percentileClosestPaths && guardrail === 'percentileClosest') {
967-
const quantiles = percentileClosestData?.quantiles ?? [];
968+
// Hardcoded percentiles: n = 5
969+
const percentiles = [5, 25, 50, 75, 95];
968970
percentileClosestPaths.forEach((line, i) => {
969971
if (line && line.lastPoint) {
970-
const percentile = Math.round((quantiles[i] ?? 0) * 100);
972+
const percentile = percentiles[i];
971973
labels.push({
972974
label: `${line.name} (${percentile}th Percentile)`,
973975
y: yScale(line.lastPoint[parameters.y_var]),

0 commit comments

Comments
 (0)